The Wayback Machine - https://web.archive.org/web/20211029141900/https://github.com/TheAlgorithms/Python/pull/5575
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decode function to base16.py #5575

Merged
merged 6 commits into from Oct 26, 2021
Merged

Add decode function to base16.py #5575

merged 6 commits into from Oct 26, 2021

Conversation

Labels
enhancement hacktoberfest-accepted
2 participants
@Rohanrbharadwaj @cclauss
@Rohanrbharadwaj
Copy link
Contributor

@Rohanrbharadwaj Rohanrbharadwaj commented Oct 24, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Rohanrbharadwaj
Add decode function
7e6c9c4
@Rohanrbharadwaj
Update base16.py
5ecf28c
@Rohanrbharadwaj
Update base16.py
1c648b5
@Rohanrbharadwaj Rohanrbharadwaj changed the title Add decode function Add decode function to base16.py Oct 25, 2021
cclauss
cclauss requested changes Oct 26, 2021
View changes
ciphers/base16.py Outdated Show resolved Hide resolved
@Rohanrbharadwaj
Update base16.py
2447bd6
@Rohanrbharadwaj
Made the line shorter
84b4956
@Rohanrbharadwaj
Made another line shorter
e232bb3
cclauss
cclauss approved these changes Oct 26, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM
@Rohanrbharadwaj
Copy link
Contributor Author

@Rohanrbharadwaj Rohanrbharadwaj commented Oct 26, 2021

👍
@cclauss cclauss merged commit 6fcefc0 into TheAlgorithms:master Oct 26, 2021
2 checks passed
@Rohanrbharadwaj Rohanrbharadwaj deleted the patch-1 branch Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment