The Wayback Machine - https://web.archive.org/web/20211026020056/https://github.com/TheAlgorithms/Python/pull/5544
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pop function #5544

Merged
merged 8 commits into from Oct 23, 2021
Merged

Update pop function #5544

merged 8 commits into from Oct 23, 2021

Conversation

@limbad-YK
Copy link
Contributor

@limbad-YK limbad-YK commented Oct 23, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
limbad-YK added 2 commits Oct 21, 2021
@limbad-YK
Updated Pop function
7402a02 
Added underflow condition
@limbad-YK
Update Pop Function
00e0a1b 
Added condition to check underflow of stack
cclauss
cclauss reviewed Oct 23, 2021
View changes
data_structures/stacks/stack.py Outdated
@@ -32,6 +34,8 @@ def push(self, data):

def pop(self):
"""Pop an element off of the top of the stack."""
if not self.stack: # Condition to check Underflow of stack
Copy link
Member

@cclauss cclauss Oct 23, 2021

Suggested change
if not self.stack: # Condition to check Underflow of stack
if not self.stack: # Condition to check Underflow of stack
cclauss
cclauss reviewed Oct 23, 2021
View changes
data_structures/stacks/stack.py Outdated
@@ -64,6 +68,7 @@ def test_stack() -> None:
assert stack.is_full() is False
assert str(stack) == "[]"
Copy link
Member

@cclauss cclauss Oct 23, 2021

Suggested change
assert str(stack) == "[]"
assert stack == []
cclauss added 6 commits Oct 23, 2021
@cclauss
Update stack.py
501af2c
@cclauss
if not self.stack: raise StackUnderflowError
904284b
@cclauss
Add doctests
2fe1dc5
@cclauss
StackUnderflowError
6efa164
@cclauss
..., not ....
91498df
@cclauss
Update stack.py
0f2bf9a
cclauss
cclauss approved these changes Oct 23, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM
@cclauss cclauss merged commit 80a885c into TheAlgorithms:master Oct 23, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
3 participants
@limbad-YK @cclauss @spartan289