Add solution for Project Euler problem 67 #5519
Merged
+40
−0
Conversation
A faster and memory efficient solution based on the template of sol1.py. Modified the solution to be more memory efficient while reading and generating the array and during the solution finding. No conditions and straightforward logic.
![algorithms-keeper[bot]](https://web.archive.org/web/20211029142550im_/https://avatars.githubusercontent.com/in/86183?s=60&v=4){kind=small}
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
franciscoperez2021
approved these changes
Oct 24, 2021
It looks good to me as I have tested locally comparing solutions with sol1.py as well as I have tested with different triangles.txt files
|
Are @Kush1101 @dhruvmanila only the reviewers here? Can't I add any other reviewers? Or no other reviewers gonna look at this because they've not assigned? |
|
@cclauss @franciscoperez2021 can you please look this? Thanks |
cclauss
reviewed
Oct 25, 2021
Preferring comprehensions over map Co-authored-by: Christian Clauss <[email protected]>
Can I please get any other reviewers @cclauss @franciscoperez2021 ? Thanks |
poyea
reviewed
Oct 28, 2021
cclauss
requested changes
Oct 28, 2021
Self explanatory variable names
cclauss
requested changes
Oct 28, 2021
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
|
It's now good to go? |
cclauss
approved these changes
Oct 28, 2021
poyea
approved these changes
Oct 28, 2021
Thank you for your pull request!
poyea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A faster and memory efficient solution based on the template of sol1.py.
Modified the solution to be more memory efficient while reading and generating the array
and during the solution finding.
No conditions and straightforward logic.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.The text was updated successfully, but these errors were encountered: