The Wayback Machine - https://web.archive.org/web/20210929223041/https://github.com/RxSwiftCommunity/RxOptional/pull/83
Skip to content

/ RxOptional Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SPM #83

Merged
merged 10 commits into from Oct 21, 2019
Merged

Add support for SPM #83

merged 10 commits into from Oct 21, 2019
+661 −168

Conversation

@minuscorp
Copy link
Contributor

@minuscorp minuscorp commented Oct 21, 2019

The new usage for release the version would be swift run rocket {VERSION_TO_RELEASE}, i.e. swift run rocket 1.0.0 This will create a tag where the test and development dependencies are hidden, I also added the typical steps for releasing the Cococapods version to trunk. Need to validate this though.
minuscorp added 10 commits Oct 21, 2019
@minuscorp
Add support for SPM
d8fd10b
@minuscorp
Fix circle build
82483d0
@minuscorp
Configure a single target for several build options
42a067f
@minuscorp
generate xcodeproj
4cb016a
@minuscorp
typo
2c5eaab
@minuscorp
Revert
b1221df
@minuscorp
Use old project
8e1301e
@minuscorp
remove plist target membership
0888fed
@minuscorp
header
081f223
@minuscorp
remove linuxmain from compile workflow
5e13ffa
@minuscorp
Copy link
Contributor Author

@minuscorp minuscorp commented Oct 21, 2019

Ready to review @ashfurrow
@minuscorp minuscorp mentioned this pull request Oct 21, 2019
Closed
@fassko fassko self-requested a review Oct 21, 2019
fassko
fassko approved these changes Oct 21, 2019
View changes
Copy link
Member

@fassko fassko left a comment

Good job! 👍
@fassko fassko merged commit acc1a2a into RxSwiftCommunity:master Oct 21, 2019
1 check passed
@rxswiftcommunity
Copy link

@rxswiftcommunity rxswiftcommunity bot commented Oct 21, 2019

Thanks a lot for contributing @minuscorp! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@minuscorp minuscorp mentioned this pull request Oct 21, 2019
Closed
@minuscorp
Copy link
Contributor Author

@minuscorp minuscorp commented Oct 21, 2019

Tag + release?
@fassko
Copy link
Member

@fassko fassko commented Oct 22, 2019

After @ashfurrow will give me access I will release it.
@minuscorp
Copy link
Contributor Author

@minuscorp minuscorp commented Oct 22, 2019

I've seen that the after step of pushing to trunk will fail because it will find that the podspec has the same version if it's not changed before launching rocket command
@freak4pc
Copy link
Member

@freak4pc freak4pc commented Oct 22, 2019

Tagged and released as 4.1.0

 🎉  Congrats

 🚀  RxOptional (4.1.0) successfully published
 📅  October 22nd, 11:17
 🌎  https://cocoapods.org/pods/RxOptional
 👍  Tell your friends!
@sunshinejr sunshinejr mentioned this pull request Oct 22, 2019
Open
@sunshinejr sunshinejr mentioned this pull request Oct 22, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@minuscorp @fassko @freak4pc