The Wayback Machine - https://web.archive.org/web/20211103082122/https://github.com/brave/brave-browser/issues/17896
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Rename Allow contribution to videos to Allow contributions for videos #17896

Open
srirambv opened this issue Sep 7, 2021 · 2 comments
Open

[Android] Rename Allow contribution to videos to Allow contributions for videos #17896

srirambv opened this issue Sep 7, 2021 · 2 comments
Assignees
@AnudeepGunukula
Labels
feature/rewards good first issue needs-text-change OS/Android priority/P4 suggestion
Projects
Android General Rewards Global

Comments

Labels
feature/rewards good first issue needs-text-change OS/Android priority/P4 suggestion
3 participants
@Miyayes @srirambv @AnudeepGunukula
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 7, 2021

Description

Similar to #16986, Rename Allow contribution to videos to Allow contributions for videos on Android as well

Steps to reproduce

  1. Open rewards page
  2. Go to AC settings
  3. Setting listed as Allow contribution to videos

Actual result

<img width=300 src=
image

Expected result

Updated text

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Related desktop issue #16986. Added same labels to the issue as desktop
@srirambv srirambv added this to Backlog in Android General via automation Sep 7, 2021
@srirambv srirambv added this to New Issues in Rewards Global via automation Sep 7, 2021
@srirambv srirambv mentioned this issue Sep 7, 2021
Open
@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Sep 7, 2021

yes @srirambv . i will make a seperate pr for Android
kindly assign this issue to me
@AnudeepGunukula AnudeepGunukula mentioned this issue Sep 8, 2021
Merged
24 tasks
@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Sep 8, 2021

Hi @srirambv . i had made a pr brave/brave-core#9999
kindly review it and please let me know the changes.
@zenparsing zenparsing moved this from New Issues to Backlog (Android) in Rewards Global Sep 8, 2021
@Miyayes Miyayes changed the title Rename Allow contribution to videos to Allow contributions for videos [Android] Rename Allow contribution to videos to Allow contributions for videos Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment