The Wayback Machine - https://web.archive.org/web/20211029142326/https://github.com/TheAlgorithms/Python/pull/5240
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random graph generator hacktoberfest #5240

Merged
merged 12 commits into from Oct 25, 2021
Merged

Random graph generator hacktoberfest #5240

merged 12 commits into from Oct 25, 2021

Conversation

Labels
hacktoberfest-accepted
3 participants
@manueldilullo @cclauss @poyea
@manueldilullo
Copy link
Contributor

@manueldilullo manueldilullo commented Oct 11, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@manueldilullo
added complete graph generator function
a078715
@manueldilullo
added doctest, type hints, wikipedia explanation
6490327
@manueldilullo
added return type hint for function complete_graph
be997e6
@manueldilullo
added descriptive name for the parameter: n
54ecb1e
@manueldilullo
random graph generator with doctest and type hints
9ac4b64
manueldilullo and others added 3 commits Oct 11, 2021
@manueldilullo
validated using pre-commit
e2d9ec1
@manueldilullo
Delete complete_graph_generator.py
5a01771
@manueldilullo
fixed doctest
bebbcac
poyea
poyea reviewed Oct 15, 2021
View changes
graphs/random_graph_generator.py Outdated Show resolved Hide resolved
poyea
poyea reviewed Oct 15, 2021
View changes
graphs/random_graph_generator.py Outdated Show resolved Hide resolved
poyea
poyea reviewed Oct 15, 2021
View changes
graphs/random_graph_generator.py Outdated
>>> random_graph(4, 1)
{0: [1, 2, 3], 1: [0, 2, 3], 2: [0, 1, 3], 3: [0, 1, 2]}
>>> random_graph(4, 1, True)
{0: [1, 2, 3], 1: [0, 2, 3], 2: [0, 1, 3], 3: [0, 1, 2]}
"""
Copy link
Member

@poyea poyea Oct 15, 2021

you can also try to use random.seed(xxx)
Copy link
Member

@cclauss cclauss Oct 15, 2021 •
edited

It would be cool if directed True and directed False did not generate exactly the same output.
Copy link
Member

@poyea poyea Oct 16, 2021

@manueldilullo I just thought that these tests generate complete graphs - but we may also make it random: https://docs.python.org/3/library/random.html#random.seed. With it, directed-ness can also be (simutaneously) tested.
Copy link
Contributor Author

@manueldilullo manueldilullo Oct 19, 2021

Oh, I didn't think about it. I couldn't find a solution for that problem by myself ahahah. I'm updating my code right now
@poyea poyea mentioned this pull request Oct 15, 2021
Closed
14 tasks
@manueldilullo
updated following reviews
cf7dc21
cclauss
cclauss reviewed Oct 15, 2021
View changes
graphs/random_graph_generator.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Oct 15, 2021
View changes
graphs/random_graph_generator.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Oct 15, 2021
View changes
graphs/random_graph_generator.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Oct 15, 2021
View changes
graphs/random_graph_generator.py Outdated Show resolved Hide resolved
@manueldilullo
simplified the code following reviews
6204ab0
cclauss
cclauss approved these changes Oct 15, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM

@poyea Anything else that you want to see?
@manueldilullo
fixed doctest and solved consistency issues
6ee751b
@manueldilullo
consistency fixes
e15b81a
poyea
poyea approved these changes Oct 25, 2021
View changes
@poyea poyea merged commit ba71005 into TheAlgorithms:master Oct 25, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment