The Wayback Machine - https://web.archive.org/web/20211027020736/https://github.com/apache/superset/issues/16995
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore] Owner can not change the name by just clicking on the title #16995

Open
2 of 3 tasks
jinghua-qa opened this issue Oct 6, 2021 · 2 comments
Open
2 of 3 tasks

[Explore] Owner can not change the name by just clicking on the title #16995

jinghua-qa opened this issue Oct 6, 2021 · 2 comments
Labels
#bug good first issue P3 Preset-QA
Projects
Community Usability Bash! 🐛🐞🕷

Comments

@jinghua-qa
Copy link
Contributor

@jinghua-qa jinghua-qa commented Oct 6, 2021 •
edited

Owner can not click and edit on the chart name when open a saved chart, can only do click edit when creating a new chart.

How to reproduce the bug

1, Explore saved chart own by you
2, Hover mouse over to chart's title
3, Click on chart title

Expected results

1,Should see tooltip "Click to edit"
2,Title is successfully edit and saved

Actual results

There is no opportunity to edit chart title by click

Screenshots

ezgif com-gif-maker (6)

Environment

(please complete the following information):

  • browser type and version: Chrome
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.
@jinghua-qa jinghua-qa added the #bug label Oct 6, 2021
@belgren
Copy link
Contributor

@belgren belgren commented Oct 7, 2021

Hi, I'd like to work on this.
@lukajeza
Copy link

@lukajeza lukajeza commented Oct 8, 2021

With JS make the text clickable, when clicked turn it in to an input field and make a save button appear. The save button should send a post request to make a change to the name in the database and redirect you back to the same page in order to apply the changes.
@belgren belgren mentioned this issue Oct 9, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug good first issue P3 Preset-QA
4 participants
@belgren @lukajeza @junlincc @jinghua-qa