The Wayback Machine - https://web.archive.org/web/20211029141640/https://github.com/TheAlgorithms/Python/pull/5598
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pollard's Rho algorithm for integer factorization #5598

Merged
merged 1 commit into from Oct 28, 2021
Merged

Add Pollard's Rho algorithm for integer factorization #5598

merged 1 commit into from Oct 28, 2021
+148 −0

Conversation

Labels
hacktoberfest-accepted
2 participants
@llamasoft @cclauss
@llamasoft
Copy link
Contributor

@llamasoft llamasoft commented Oct 25, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@llamasoft
Add Pollard's Rho algorithm for integer factorization
fdebece
@llamasoft llamasoft requested a review from Kush1101 as a code owner Oct 25, 2021
@llamasoft
Copy link
Contributor Author

@llamasoft llamasoft commented Oct 28, 2021

@cclauss is it possible to request an additional reviewer?
It appears that Kush1101 hasn't done any reviews in almost a year.

Also, apologies for pinging you directly but I saw that you were active recently. 😰
@cclauss cclauss merged commit 5c8a6c8 into TheAlgorithms:master Oct 28, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment