The Wayback Machine - https://web.archive.org/web/20211030094705/https://github.com/microsoft/react-native-windows/pull/8908
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix win32 apps that want to use the RNW nuget package #8908

Merged
merged 2 commits into from Oct 23, 2021
Merged

Fix win32 apps that want to use the RNW nuget package #8908

merged 2 commits into from Oct 23, 2021

Conversation

Labels
AutoMerge Request Backport to 0.66
2 participants
@asklar @chrisglein
@asklar
Copy link
Member

@asklar asklar commented Oct 22, 2021 •
edited by msftbot bot

Currently the nuget package's targets file filters out consuming projects, so that only UWP apps get the microsoft.reactnative.winmd reference. This prevents win32 apps that want to use the nuget package from building.

Fixes #8894

Microsoft Reviewers: Open in CodeFlow
asklar added 2 commits Oct 22, 2021
@asklar
Fix win32 apps referencing the M.RN nuget package so they can use RNW
a0f1580
@asklar
Change files
160e69a
@asklar asklar requested a review from as a code owner Oct 22, 2021
@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Oct 22, 2021

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
@chrisglein
Copy link
Member

@chrisglein chrisglein commented Oct 22, 2021

This prevents win32 apps that want to use the nuget package from building.

Any appropriate tests we can add for this?
@msftbot msftbot bot merged commit e18fd3f into microsoft:main Oct 23, 2021
40 checks passed
@asklar asklar deleted the win32 branch Oct 23, 2021
@asklar
Copy link
Member Author

@asklar asklar commented Oct 23, 2021

This prevents win32 apps that want to use the nuget package from building.

Any appropriate tests we can add for this?

I'll add an app to the CI build once we have things working end-to-end
@asklar asklar mentioned this pull request Oct 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment