The Wayback Machine - https://web.archive.org/web/20211030090117/https://github.com/microsoft/react-native-windows/pull/4125
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Drop StdCall in favor of Cdecl for x86. (#4115)" #4125

Merged
merged 2 commits into from Feb 19, 2020

Conversation

3 participants
@NickGerleman
Copy link
Contributor

@NickGerleman NickGerleman commented Feb 19, 2020

This reverts commit 0a432a1.

The change has led to some breakage, and there is new information about
Office's needs for the change. Revert this change in master until we
have something fully working, and have a better plan figured out.

Microsoft Reviewers: Open in CodeFlow
This reverts commit 0a432a1.

The change has led to some breakage, and there is new information about
Office's needs for the change. Revert this change in master until we
have something fully working.
@NickGerleman NickGerleman requested a review from as a code owner Feb 19, 2020
@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Feb 19, 2020

Hello @NickGerleman!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 56 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
@JunielKatarn
Copy link
Contributor

@JunielKatarn JunielKatarn commented Feb 19, 2020

What was the breakage?

@NickGerleman
Copy link
Contributor Author

@NickGerleman NickGerleman commented Feb 19, 2020

What was the breakage?

react-cli and the publish pipeline are broken due to the submodules change

@msftbot msftbot bot merged commit d89f2cb into microsoft:master Feb 19, 2020
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment