The Wayback Machine - https://web.archive.org/web/20200424112734/https://github.com/reactioncommerce/reaction/issues/5708/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default timeout for integration tests #5708

Open
mpaktiti opened this issue Oct 9, 2019 · 0 comments
Open

Default timeout for integration tests #5708

mpaktiti opened this issue Oct 9, 2019 · 0 comments

Comments

@mpaktiti
Copy link
Contributor

@mpaktiti mpaktiti commented Oct 9, 2019

Issue Description

Currently some integration tests set the default timeout interval individually, using jest.setTimeout(300000). According to JEST docs it's better if this is something we want to do for all test files, it should be done in setupFilesAfterEnv.

We want to set a default timeout centrally but have it apply only on INTEGRATION tests, not on UNIT tests. We also want to lower the value since 5 minutes does not make sense any longer (we used to spin up mongo once per file but now it’s only once before the first test runs.)

Possible Solution

  • set the default timeout in setupFilesAfterEnv but make it conditional based on an env that we set only for integration tests
  • remove the individual jest.setTimeout(300000) from all integration files
@mpaktiti mpaktiti added the testing label Oct 9, 2019
@mpaktiti mpaktiti self-assigned this Oct 9, 2019
@aldeed aldeed added this to To do in Post-3.0.0 via automation Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.