Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Closed
Description
When using static routes with a falcon.asgi.App, it seems that the _AsyncFileReader wrapper does not implement any .close() method, so files are left open.
On CPython, I wasn't able to demonstrate any practical impact of this bug as the file object in question is refcounted to 0 and garbage collected as soon as it goes out of scope. However, that isn't the case when running uvicorn on PyPy 3.7, as PyPy uses a different GC implementation.
Test case in point:
import io
import logging
import os.path
import unittest.mock
import falcon.asgi
logging.basicConfig(
format='%(asctime)s [%(levelname)s] %(message)s', level=logging.INFO)
class DebugIO(io.BytesIO):
@classmethod
def open(cls, *args, **kwargs):
return cls(b'Test data!\n')
def close(self):
logging.info(f'{self}.close()')
super().close()
app = falcon.asgi.App()
app.add_static_route('/files', '/tmp')
debug = unittest.mock.patch('io.open', DebugIO.open)
debug.start()