The Wayback Machine - https://web.archive.org/web/20211017081245/https://github.com/TheAlgorithms/Python/pull/4814
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypy] Added type annotations to disjoint_set.py #4814

Merged
merged 1 commit into from Oct 11, 2021
Merged

[mypy] Added type annotations to disjoint_set.py #4814

merged 1 commit into from Oct 11, 2021

Conversation

@scfenton6
Copy link
Contributor

@scfenton6 scfenton6 commented Oct 1, 2021

Added type annotations in the program disjoint_set.py, located in the data_structures/disjoint_set folder. I also capitalized some words in the docstring and comments.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
poyea
poyea approved these changes Oct 11, 2021
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩

@poyea poyea merged commit abaa0d7 into TheAlgorithms:master Oct 11, 2021
2 checks passed
@scfenton6 scfenton6 deleted the mypy-fix branch Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants