The Wayback Machine - https://web.archive.org/web/20211120105453/https://github.com/TheAlgorithms/Python/pull/5335
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runnable example and add tests. #5335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix runnable example and add tests. #5335

wants to merge 2 commits into from

Conversation

@programmin1
Copy link

@programmin1 programmin1 commented Oct 16, 2021

Describe your change:

Just adding some doc testing, make file runnable with example use.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss
cclauss reviewed Oct 16, 2021
View changes
matrix/rotate_matrix.py Outdated Show resolved Hide resolved
Loading
@programmin1 @cclauss
Update matrix/rotate_matrix.py
cf2e9b4 
Co-authored-by: Christian Clauss <[email protected]>
@programmin1
Copy link
Author

@programmin1 programmin1 commented Oct 21, 2021

What does that mean, "Oh no! 💥 💔 💥
3 files would be reformatted, 936 files would be left unchanged."
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 21, 2021 •
edited
Loading

That message comes from https://github.com/psf/black.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews enhancement tests are failing
2 participants
@programmin1 @cclauss