more fine-grained connection errors on Windows #23
Conversation
|
Could you please update the error codes in OutlineVpn.swift and PacketTunnelProvider.h? |
|
@albertolalama Done! Damn, adding these is more expensive than I thought. I also updated the comments on each. |
|
Thanks! We could create a framework to share these between the app and VpnExtension process. |
trevj
merged commit 1755961
into
master
2 checks passed
2 checks passed
cla/google
All necessary CLAs are signed
trevj
added a commit
that referenced
this pull request
Mar 23, 2018
Hmm, think I forgot to `git push` this when merging #23.
Merged
trevj
added a commit
that referenced
this pull request
Mar 23, 2018
Hmm, think I forgot to `git push` this when merging #23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Seeing a bunch of connection error reports coming in on Windows but the breadcrumbs only tell me:
Two changes:
console.logstatements that might leak server IPs to us.