The Wayback Machine - https://web.archive.org/web/20211014134442/https://github.com/facebook/react/pull/22465
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Link on Documentation #22465

Merged
merged 1 commit into from Sep 30, 2021
Merged

Fixed Link on Documentation #22465

merged 1 commit into from Sep 30, 2021

Conversation

@aaronamendez
Copy link
Contributor

@aaronamendez aaronamendez commented Sep 29, 2021

The Documentation link via https://reactjs.org/docs on line 23 doesn't work and shows an Page Not Found Error page handler.

This change fixes the UX a bit for now, we could also default it to (https://reactjs.org/docs/getting-started.html) however this creates a bit of redundancy.

Summary

How did you test this change?
@aaronamendez
Fixed Link on Documentation
3dd4cc7 
The Documentation link via https://reactjs.org/docs on line 23 doesn't work and shows an Page Not Found Error page handler.

This change fixes the UX a bit for now, we could also default it to (https://reactjs.org/docs/getting-started.html) however this creates a bit of redundancy.
@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Sep 29, 2021

Hi @aaronamendez!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
@sizebot
Copy link

@sizebot sizebot commented Sep 29, 2021

Comparing: 201af81...3dd4cc7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.22 kB 130.22 kB = 41.45 kB 41.45 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 133.05 kB 133.05 kB = 42.42 kB 42.42 kB
facebook-www/ReactDOM-prod.classic.js = 412.61 kB 412.61 kB = 76.37 kB 76.37 kB
facebook-www/ReactDOM-prod.modern.js = 401.23 kB 401.23 kB = 74.67 kB 74.67 kB
facebook-www/ReactDOMForked-prod.classic.js = 412.61 kB 412.61 kB = 76.37 kB 76.38 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3dd4cc7

@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Sep 29, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
@bvaughn bvaughn merged commit ec4ac97 into facebook:main Sep 30, 2021
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed
5 participants
@aaronamendez @facebook-github-bot @sizebot @bvaughn @crypt096