The Wayback Machine - https://web.archive.org/web/20210106024256/https://github.com/projectcontour/gimbal/issues/225
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve goroutine and error handling in the discoverers #225

Open
alexbrand opened this issue Aug 23, 2018 · 0 comments
Open

Improve goroutine and error handling in the discoverers #225

alexbrand opened this issue Aug 23, 2018 · 0 comments

Comments

@alexbrand
Copy link
Contributor

@alexbrand alexbrand commented Aug 23, 2018

Use heptio/workgroup to improve handling of the multiple goroutines that are spawned in each of the discoverers. This will also help us to bubble up errors to main, and handle them appropriately.

An example of this is #224. We wanted to handle the case where re-auth failed 3 times, but there was no good way of bubbling up the error to main.go. We could make reconciler.Run return an error to bubble it up to main.go, and use heptio/workgroup to handle the goroutine part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.