The Wayback Machine - https://web.archive.org/web/20211013190057/https://github.com/golang/go/pull/48785
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed: add example #48785

Closed
wants to merge 5 commits into from
Closed

embed: add example #48785

wants to merge 5 commits into from

Conversation

@helbing
Copy link
Contributor

@helbing helbing commented Oct 5, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 5, 2021

This PR (HEAD: 7b35b6d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/353936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 5, 2021

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 5, 2021

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 5, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 5, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 5, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2021

This PR (HEAD: 962c9ca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/353936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2021

Message from Bruce Huang:

Patch Set 3:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2021

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

This PR (HEAD: 073cdf4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/353936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

Message from Bruce Huang:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

Message from Ian Lance Taylor:

Patch Set 4: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

Message from Go Bot:

Patch Set 4:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

Message from Go Bot:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

Message from Go Bot:

Patch Set 4: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 12, 2021

This PR (HEAD: 8d29b73) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/353936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 12, 2021

Message from Bruce Huang:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2021

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2021

Message from Go Bot:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2021

Message from Go Bot:

Patch Set 5: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2021

Message from Ian Lance Taylor:

Patch Set 5: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/353936.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this issue Oct 13, 2021
Change-Id: I4e50e469047ac7efbf4ed464e238000dbdf53d6b
GitHub-Last-Rev: 8d29b73
GitHub-Pull-Request: #48785
Reviewed-on: https://go-review.googlesource.com/c/go/+/353936
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2021

This PR is being closed because golang.org/cl/353936 has been merged.

@gopherbot gopherbot closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants