The Wayback Machine - https://web.archive.org/web/20211010043735/https://github.com/bevyengine/bevy/pull/1903
Skip to content

/ bevy Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Cargo fmt with unstable features #1903

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Cargo fmt with unstable features #1903

wants to merge 2 commits into from

Conversation

@alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Apr 13, 2021

Fresh version of #1670 off the latest main.

Mostly fixing documentation wrapping.
@alice-i-cecile
Copy link
Member Author

@alice-i-cecile alice-i-cecile commented Apr 13, 2021

This is just cargo fmt using the unstable cargo fmt features from rustfmt.toml.
bjorn3
bjorn3 reviewed Apr 13, 2021
View changes
crates/bevy_render/src/mesh/mesh.rs Outdated
/// Where the vertex is located in space. Use in conjunction with [`Mesh::set_attribute`]
pub const ATTRIBUTE_POSITION: &'static str = "Vertex_Position";
/// The direction of the vertex tangent. Used for normal mapping
pub const ATTRIBUTE_TANGENT: &'static str = "Vertex_Tangent";
Copy link
Contributor

@bjorn3 bjorn3 Apr 13, 2021

This should stay next to normal.
Copy link
Member Author

@alice-i-cecile alice-i-cecile Apr 13, 2021

How do I signal to cargo fmt not to immediately make this change again?
Copy link
Contributor

@bjorn3 bjorn3 Apr 13, 2021

#[rustfmt::ignore] maybe?
Copy link
Member Author

@alice-i-cecile alice-i-cecile Apr 13, 2021

Nope, crashes with error: invalid attribute.

Looks like #[rustfmt::skip] is the correct incantation.
Copy link
Member Author

@alice-i-cecile alice-i-cecile Apr 13, 2021

Which, of course, doesn't actually stop it from reordering. @bjorn3, before I waste an hour on this, how much do you care?
Copy link
Member

@DJMcNab DJMcNab Apr 13, 2021 •
edited

I personally think we could just as easily disable the option - 7212b70 doesn't explain why it was enabled.

Additionally, it currently seems like the option, to put it kindly, needs work - see rust-lang/rustfmt#2792 (comment)
Copy link
Member Author

@alice-i-cecile alice-i-cecile Apr 13, 2021

I agree with you there. @cart, do we have your blessing?
Copy link
Contributor

@cart cart Apr 15, 2021

Yup lets just disable it. Using order to semantically group things does seem valid in some contexts.
Copy link
Member Author

@alice-i-cecile alice-i-cecile Apr 21, 2021

This option has been removed!
@alice-i-cecile
Removed reorder_impl_items
479bfe6 
Not desired behavior
@alice-i-cecile
Nightly formatting
95d0f0d
@alice-i-cecile
Copy link
Member Author

@alice-i-cecile alice-i-cecile commented Apr 21, 2021

@cart this is done now with the option removed. Please merge this ASAP so I can stop rebasing <3
@cart
Copy link
Contributor

@cart cart commented Apr 21, 2021

bors r+
bors bot pushed a commit that referenced this issue Apr 21, 2021
@alice-i-cecile
Cargo fmt with unstable features (#1903)
e4e3259 
Fresh version of #1670 off the latest main.

Mostly fixing documentation wrapping.
@bors
Copy link

@bors bors bot commented Apr 21, 2021

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Cargo fmt with unstable features [Merged by Bors] - Cargo fmt with unstable features Apr 21, 2021
@bors bors bot closed this Apr 21, 2021
ostwilkens added a commit to ostwilkens/bevy that referenced this issue Jul 27, 2021
@alice-i-cecile @ostwilkens
Cargo fmt with unstable features (bevyengine#1903)
126702f 
Fresh version of bevyengine#1670 off the latest main.

Mostly fixing documentation wrapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System C-Code-Quality C-Docs S-Ready-For-Final-Review
4 participants
@alice-i-cecile @cart @bjorn3 @DJMcNab