Pinned
1,481 contributions in the last year
Less
More
Activity overview
Contribution activity
October 2021
Created 2 commits in 1 repository
Created a pull request in ampproject/amphtml that received 4 comments
π Correctly detect P tags as text element types
The LCP's target is an element, but I had assumed it would be a #text node if the LCP was textual. When we retrieve the outermost element, it'll beβ¦
+33
β11
•
4
comments
Opened 2 other pull requests in 1 repository
ampproject/amphtml
1
merged
1
open
Reviewed 19 pull requests in 4 repositories
ampproject/amphtml
15 pull requests
- unobserveIntersection: fix typo
- bento unit tests: flush all hooks/renders after each test run
-
β»οΈ core: add getWin to core/window - BaseElement: remove .getWin()
-
β»οΈ Move files into #core, #utils to enable tsc typechecking -
π Sort video sources by tuples of (codec, bitrate) and append codec information to the video's type attribute -
π Use timeOrigin for getFirstVisibleTime when page starts visible -
π Correctly detect P tags as text element types -
π Only create poster element when attribute is provided -
π Wrap native HTMLElement for extension - Rename viewportCallbackTemp --> viewportCallback
-
π Propagate importance -
β¨ Allowimportanceattribute on SSR'edamp-img > img -
π babel/terser: rename all amp privates with sentinel suffix -
π¦ Update dependency @ampproject/google-closure-compiler to v20210907

