The Wayback Machine - https://web.archive.org/web/20210802020724/https://github.com/PointCloudLibrary/pcl/issues/4718
Skip to content

/ pcl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search] Convert "test" to benchmark #4718

Open
kunaltyagi opened this issue Apr 22, 2021 · 2 comments
Open

[search] Convert "test" to benchmark #4718

kunaltyagi opened this issue Apr 22, 2021 · 2 comments
Labels
good first issue kind: todo module: benchmarks

Comments

@kunaltyagi
Copy link
Member

@kunaltyagi kunaltyagi commented Apr 22, 2021

This "test" doesn't really belong here?

It seems to capture processing times, but don't print or use them / compare them?

Originally posted by @larshg in #4712 (comment)
@ueqri ueqri mentioned this issue Apr 30, 2021
Merged
@mvieth mvieth changed the title Convert "test" to benchmark (after benchmarks are added) [search] Convert "test" to benchmark Jun 30, 2021
@mvieth
Copy link
Member

@mvieth mvieth commented Jun 30, 2021

For anyone interested: benchmarks are added now, you can orient yourself at the existing benchmark(s).
@kunaltyagi
Copy link
Member Author

@kunaltyagi kunaltyagi commented Jul 1, 2021

Added a new label for the new module. Should have done that before :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue kind: todo module: benchmarks
2 participants
@kunaltyagi @mvieth