The Wayback Machine - https://web.archive.org/web/20211128132231/https://github.com/mssun/passforios/issues/208
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations? #208

Open
x4m3 opened this issue Aug 16, 2018 · 10 comments
Open

translations? #208

x4m3 opened this issue Aug 16, 2018 · 10 comments

Comments

@x4m3
Copy link

@x4m3 x4m3 commented Aug 16, 2018

hi,
is it possible to translate the app in other languages? i'd be happy to send a pr :)

i dont know ios development, so i dont know how to implement multiple languages.

thanks

@mssun
Copy link
Owner

@mssun mssun commented Aug 16, 2018

I'm happy to work on localization an i8n. I don't know exactly how iOS handle this, but I would like to work on this. I guess we should extract strings and come up a table to different languages.

@SimplyDanny
Copy link
Contributor

@SimplyDanny SimplyDanny commented Jan 14, 2019

I have started to work on this one. As this is some effort, I just wanted to inform you to avoid duplicated work.

@mssun
Copy link
Owner

@mssun mssun commented Jan 15, 2019

@SimplyDanny Thank you so much. Probably, you have to refactor some code to support multi languages.

@SimplyDanny
Copy link
Contributor

@SimplyDanny SimplyDanny commented Jan 15, 2019

Yes, I have already noticed that. But so far, I’m making some progress.

@mssun
Copy link
Owner

@mssun mssun commented Jan 15, 2019

@SimplyDanny You can put them in separate PRs.

@x4m3
Copy link
Author

@x4m3 x4m3 commented Jan 15, 2019

if you need help for translating strings in french, i can help! (and maybe russian too)

@SimplyDanny
Copy link
Contributor

@SimplyDanny SimplyDanny commented Jan 15, 2019

I would propose I finish the work for the English part first. The result will contain at least two files with strings which may be translated into other languages. This can be done in separate PRs. Of course you can already start to find appropriate translations for all the strings in the app. 😉

@SimplyDanny
Copy link
Contributor

@SimplyDanny SimplyDanny commented Jan 21, 2019

Now that #242 is merged people can work on translations. Perhaps we could use this thread to list who is working on which language.

@SimplyDanny
Copy link
Contributor

@SimplyDanny SimplyDanny commented Jan 21, 2019

Myself can do the German. 🇩🇪

@x4m3
Copy link
Author

@x4m3 x4m3 commented Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment