The Wayback Machine - https://web.archive.org/web/20211017081229/https://github.com/TheAlgorithms/Python/pull/4350
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNN classification added to computer vision #4350

Merged
merged 33 commits into from Jun 24, 2021
Merged

CNN classification added to computer vision #4350

merged 33 commits into from Jun 24, 2021

Conversation

@9harshit
Copy link
Contributor

@9harshit 9harshit commented Apr 23, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
9harshit added 11 commits Apr 22, 2021
@9harshit
cnn classification file
629fd8a
@9harshit
Update cnn_classification.py
c104a73
@9harshit
Delete cnn_classification.py
054fdc7
@9harshit
cnn classifcation added
d575ef1
@9harshit
cnn classification added
e24fdf6
@9harshit
Update cnn_classification.py
62785b7
@9harshit
Update cnn_classification.py
96714a3
@9harshit
Update cnn_classification.py
61a8e65
@9harshit
Update cnn_classification.py
9e9aa1c
@9harshit
black formatted
5d93c27
@9harshit
flake8 corrected
b27e7af
9harshit added 2 commits Apr 23, 2021
@9harshit
Add files via upload
24bb00e
@9harshit
added dataset link
96a770e
dhruvmanila
dhruvmanila requested changes Apr 27, 2021
View changes
computer_vision/cnn_classification.py Outdated Show resolved Hide resolved
computer_vision/cnn_classification.py Outdated Show resolved Hide resolved
9harshit added 2 commits Apr 27, 2021
@9harshit
Delete cnn_classification.py
9f0064b
@9harshit
added cnn classification
f6b14d8
9harshit added 4 commits Apr 27, 2021
@9harshit
Update cnn_classification.py
2e5ccbd
@9harshit
Update cnn_classification.py
7981c4a
@9harshit
Update cnn_classification.py
ab1e53d
@9harshit
Delete requirements.txt
ca54ea0
@dhruvmanila dhruvmanila self-assigned this Apr 27, 2021
9harshit added 3 commits Apr 27, 2021
@9harshit
Update cnn_classification.py
c8ff175
@9harshit
Create cnn_classification.py
8d12d8d
@9harshit
Add files via upload
ecd4161
9harshit added 2 commits Apr 30, 2021
@9harshit
using keras from tensorflow only
201d636
@9harshit
update tensorflow
89e0107
@9harshit 9harshit requested a review from dhruvmanila Apr 30, 2021
dhruvmanila
dhruvmanila requested changes May 23, 2021
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Good job so far!

Another doubt: does this fall under computer vision or should be in the machine learning, I don't know much about it so you can guide me on this one :)

You should either turn on pre-commit (instruction in CONTRIBUTING.md) or look at the logs and fix the errors (mostly it would be related to formatting). Running black should be done as well.
@9harshit
Add files via upload
2c83aaf
@9harshit
Add files via upload
c43489d
@9harshit
Copy link
Contributor Author

@9harshit 9harshit commented May 24, 2021 •
edited

Good job so far!

Another doubt: does this fall under computer vision or should be in the machine learning, I don't know much about it so you can guide me on this one :)

You should either turn on pre-commit (instruction in CONTRIBUTING.md) or look at the logs and fix the errors (mostly it would be related to formatting). Running black should be done as well.

  1. Computer Vision comes under Machine learning but since the repo had a dedicated section for CV I added the code in Computer Vision who's description states : "While computer vision comes from modelling image processing using the techniques of machine learning, computer vision applies machine learning to recognize patterns for interpretation of images"

  2. I already ran pre-commit, black ,flake8 before pushing the file as asked earlier
9harshit added 5 commits May 24, 2021
@9harshit
Merge branch 'TheAlgorithms:master' into master
abdabda
@9harshit
Update cnn_classification.py
4ac3d3b
@9harshit
Add files via upload
a3b550c
@9harshit
Add files via upload
3b100ec
@9harshit
changes made
9c3b895
@9harshit
Copy link
Contributor Author

@9harshit 9harshit commented Jun 23, 2021

Hi, is there still issue with my code ? my code hasn't been merged
dhruvmanila
dhruvmanila requested changes Jun 24, 2021
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Sorry for taking so long and thank you for your patience! This looks like it's ready to be merged except for just one nitpick :)

Also, there's no need to create a directory for one file, you can put the file on it's own in computer_vision/cnn_classification.py
computer_vision/cnn_classification/cnn_classification.py Outdated Show resolved Hide resolved
@9harshit
Delete computer_vision/cnn_classification directory
57f85c6
@9harshit
Add files via upload
0e28801
dhruvmanila
dhruvmanila approved these changes Jun 24, 2021
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

LGTM! 🎉

Thank you for your contribution and welcome to the community!
@dhruvmanila dhruvmanila merged commit 2899cda into TheAlgorithms:master Jun 24, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@9harshit @dhruvmanila