The Wayback Machine - https://web.archive.org/web/20211002012845/https://github.com/great-expectations/great_expectations/issues/1859
Skip to content

/ great_expectations Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials are written to config_variables.yml even if datasource creation is aborted #1859

Open
spbail opened this issue Aug 28, 2020 · 4 comments
Open

Credentials are written to config_variables.yml even if datasource creation is aborted #1859

spbail opened this issue Aug 28, 2020 · 4 comments
Labels
bug community feature:cli good first issue stale

Comments

@spbail
Copy link
Contributor

@spbail spbail commented Aug 28, 2020

Describe the bug
This is basically one of the issues I called out in #1855:
When I run datasource new and exit the process at any point (e.g. ctrl+c), I still get a block for the credentials in config_variables.yml. However great_expectations.yml doesn't have the datasource entry. I would expect any kind of failure in the datasource creation process to not leave any artifacts.

To Reproduce
Steps to reproduce the behavior:

  • run great_expectations datasource new
  • pick a SQLalchemy datasource (not tested with file datasources, but might be the same)
  • just hit enter on any of the inputs
  • ctrl+c to exit the process, or exit when prompted to re-enter the incorrect creds
  • open uncomitted/config_variables.yml - it will have an entry for the datasource creds, which is unexpected behavior
  • open great_expectations.yml - it won't have an entry for the datasource (which is expected behavior)

Expected behavior
I would expect any failure in the CLI workflows to not leave artifacts. This is similar to another issues I've filed where suite new also leaves a suite JSON even if the creation process fails/is canceled. I would expect GE to be better at cleanup/not leave artifacts if the CLI workflow fails at any point.

Environment (please complete the following information):

  • OS: mac OS
  • GE Version: 0.12.0
@spbail spbail mentioned this issue Aug 28, 2020
Closed
@felipebormann
Copy link

@felipebormann felipebormann commented Dec 28, 2020

Can I tackle this problem? Or is it addressed somewhere else already?
@spbail
Copy link
Contributor Author

@spbail spbail commented Dec 28, 2020

Hi @felipebormann I'd try and reproduce the issue first, but I'm pretty sure this hasn't been fixed yet. You're more than welcome to tackle this!
@alfredo-f
Copy link

@alfredo-f alfredo-f commented Apr 4, 2021

Now, when creating a new datasource, the Jupyter notebook that opens up reads

Credentials will not be saved until you run the last cell. The credentials will be saved in uncommitted/config_variables.yml which should not be added to source control.

@anthonyburdi Has this issue been solved?
@github-actions
Copy link

@github-actions github-actions bot commented Jul 4, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?\n\nThis issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@github-actions github-actions bot added the stale label Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug community feature:cli good first issue stale
4 participants
@spbail @alfredo-f @petermoyer @felipebormann