The Wayback Machine - https://web.archive.org/web/20211005224313/https://github.com/apache/superset/pull/12284
Skip to content

/ superset Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove (some) references to incubating/incubation #12284

Merged
merged 1 commit into from Jan 6, 2021
Merged

docs: remove (some) references to incubating/incubation #12284

merged 1 commit into from Jan 6, 2021

Conversation

@nytai
Copy link
Member

@nytai nytai commented Jan 5, 2021 •
edited

SUMMARY

Since we have graduated and the incubator prefix has been removed from the repo let's start the process of removing some of these references. There are likely many more references in the repo however these seemed like a good place to start.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • 👀

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API
ktmud
ktmud reviewed Jan 5, 2021
View changes
Copy link
Member

@ktmud ktmud left a comment

👏 👏
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 5, 2021 •
edited

Codecov Report

Merging #12284 (fa9d3af) into master (9eb911d) will decrease coverage by 4.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12284      +/-   ##
==========================================
- Coverage   67.14%   62.96%   -4.19%     
==========================================
  Files        1002     1002              
  Lines       49300    49286      -14     
  Branches     5010     5010              
==========================================
- Hits        33104    31031    -2073     
- Misses      16071    18053    +1982     
- Partials      125      202      +77
Flag Coverage Δ
cypress ?
javascript 61.20% <ø> (ø)
python 64.10% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb911d...fa9d3af. Read the comment docs.
@mistercrunch mistercrunch mentioned this pull request Jan 5, 2021
Closed
@ktmud
Copy link
Member

@ktmud ktmud commented Jan 6, 2021

CI is failing for no reason. Might need a rebase?
riahk
riahk approved these changes Jan 6, 2021
View changes
@nytai
docs: remove (some) references to incubating/incubation
fa9d3af
@nytai nytai force-pushed the tai/remove-incubation-refs branch from 4ad108b to fa9d3af Jan 6, 2021
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Jan 6, 2021
@nytai nytai merged commit 176f54d into apache:master Jan 6, 2021
22 checks passed
@nytai nytai deleted the tai/remove-incubation-refs branch Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset-io size/XS
6 participants
@nytai @codecov-io @ktmud @willbarrett @dpgaspar @riahk