Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDismissing Modal with Hero disabled causes black screen #656
Assignees
Comments
|
I temporary fixed this issue by renabling hero when dismissing and setting My only issue now is the hero dismiss animation adds a dark shadow on the modal when dismissing which looks like a black line when the VC is dismissing. I want to get rid of it entirely so it stays white. How do I do that?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@JoeMatt
What did you do?
I present a modal with
vc.modalPresentationStyle = .overCurrentContextThe presentingVC is a chat app VC with a list of chats. The chatCell's have a titleLabel who's heroId is the same as the Modal VC's navigationBar titleLabel.
The presentation animation works beautifully there's no problem here.
What did you expect to happen?
When I dismiss, I don't want the same match animation that was used to present the modal. Instead I want it to dismiss normally with the default iOS modal dismiss animation.
To achieve this, I set
hero.isEnabled = falsein my modal VC right before callingdismiss(animated: true..)What happened instead?
Instead what happens is the modal will dismiss, I briefly see the my presenting VC with the cell that was tapped having it's subviews out of position. Then the view goes black. I debug the view hierarchy and it appears as if even my root viewController is dismissed so there's literally no rootVC in my viewhierachy.
How do I fix this to have a normal dismiss without Hero match animation?
General Information
Hero Version: 1.5.0
iOS Version(s): 11
Swift Version: 5
Devices/Simulators: Device
Demo Project