Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add stopAt option
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Sep 16, 2021
readme.md
Outdated
| Type: `string`\ | ||
| Default: `path.parse(cwd).root` | ||
|
|
||
| The absolute path to the directory to stop the search before reaching root if there were no matches before the `stopAt` directory. |
There was a problem hiding this comment.
Why does it have to be an absolute path? I think you can just path.resolve(cwd, stopAt) the input path you get from the user.
|
Thanks for working on this. You need to add types to index.d.ts too. |
|
Thanks for the feedback. Fixed both issues in: Could you please have a look? |
sindresorhus
requested changes
Sep 19, 2021
index.d.ts
Outdated
| @@ -8,6 +8,8 @@ export const findUpStop: unique symbol; | |||
|
|
|||
| export type Match = string | typeof findUpStop | undefined; | |||
|
|
|||
| export type Options = LocatePathOptions & {stopAt?: string}; | |||
There was a problem hiding this comment.
The stopAt option needs docs: https://github.com/sindresorhus/typescript-definition-style-guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #49.