Fix TypeScript eslint Config #5980
Merged
Conversation
NickGerleman
requested a review
from microsoft/react-native-windows-write
as a
code owner
| ControlStyleTestPage.toggleControlBorder(); | ||
| const result = ControlStyleTestPage.getTreeDumpResult(); | ||
| const result = await ControlStyleTestPage.getTreeDumpResult(); |
NickGerleman
Sep 13, 2020
Author
Contributor
It looks like fixing the broken 100ms wait leads to this no longer working. Not sure if we should remove the wait or what is going on here quite yet.
It looks like fixing the broken 100ms wait leads to this no longer working. Not sure if we should remove the wait or what is going on here quite yet.
|
|
NickGerleman
merged commit 2df3273
into
microsoft:master
32 checks passed
32 checks passed
PR (Universal Other Projects PR X64Release)
Universal Other Projects PR X64Release succeeded
Details
PR (Verify react-native init ArmReleaseCpp)
Verify react-native init ArmReleaseCpp succeeded
Details
PR (Verify react-native init WinUI3_X86DebugCpp)
Verify react-native init WinUI3_X86DebugCpp succeeded
Details
PR (Verify react-native init WinUI3_X86DebugCs)
Verify react-native init WinUI3_X86DebugCs succeeded
Details
PR (Verify react-native init X64ReleaseCpp)
Verify react-native init X64ReleaseCpp succeeded
Details
PR (Verify react-native init X86DebugCppLib)
Verify react-native init X86DebugCppLib succeeded
Details
PR (Verify react-native init X86DebugCsLib)
Verify react-native init X86DebugCsLib succeeded
Details
PR (Verify react-native init experimental cpp)
Verify react-native init experimental cpp succeeded
Details
PR (Verify react-native init experimental cs)
Verify react-native init experimental cs succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I discovered that the recent change I made to use new plugins was only functioning on tsx files due to an invalid glob. I fixed that, fixed a couple more usages, and discovered VSCode will actually correctly resolve monorepo eslint config files, letting us avoid the dual configs and getting full eslint coverage in VSCode.
Microsoft Reviewers: Open in CodeFlow