The Wayback Machine - https://web.archive.org/web/20210830105928/https://github.com/faruktoptas/FancyShowCaseView/issues/212
Skip to content

/ FancyShowCaseView

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus size factor for rectangular shape #212

Open
faruktoptas opened this issue Sep 23, 2020 · 10 comments
Open

Add focus size factor for rectangular shape #212

faruktoptas opened this issue Sep 23, 2020 · 10 comments
Labels
beginner feature-request first-timers-only good first issue

Comments

@faruktoptas
Copy link
Owner

@faruktoptas faruktoptas commented Sep 23, 2020

Add focusRectSizeFactor parameter for rectangle focus shape (like focusCircleRadiusFactor for circular). Default value should be 1.
@faruktoptas faruktoptas mentioned this issue Sep 23, 2020
Closed
@HoussemNasri
Copy link

@HoussemNasri HoussemNasri commented Jan 19, 2021

Is this still open, I wanna work on it
@faruktoptas
Copy link
Owner Author

@faruktoptas faruktoptas commented Jan 19, 2021

@HoussemNasri yes please.
@HoussemNasri HoussemNasri mentioned this issue Jan 20, 2021
Closed
@Kritip123
Copy link

@Kritip123 Kritip123 commented Aug 18, 2021 •
edited

@faruktoptas

I want to contribute to the issue. Could you please explain the issue to me? Actually, I am new to open source
@faruktoptas
Copy link
Owner Author

@faruktoptas faruktoptas commented Aug 24, 2021 •
edited

Hi @Kritip123,

Sorry for the late response :)

Same implementation is done for circular focus. Please see focusCircleRadiusFactor. You will add a new parameter called focusRectSizeFactor with 1 default float value. When this value is changed, focused rectangle will be bigger or smaller.
@kshitij-99
Copy link

@kshitij-99 kshitij-99 commented Aug 28, 2021

@faruktoptas is someone still working on this ? I can fix this.
@faruktoptas
Copy link
Owner Author

@faruktoptas faruktoptas commented Aug 28, 2021 •
edited

Hi @kshitij-99,

I'm not sure that if @Kritip123 is working on this issue. You can start if he didn't start yet.
@kshitij-99
Copy link

@kshitij-99 kshitij-99 commented Aug 28, 2021

@Kritip123 are you working on this ?
@Kritip123
Copy link

@Kritip123 Kritip123 commented Aug 28, 2021

@faruktoptas and @kshitij-99 I was not able to set up the codebase using Android Studio in my system. It was giving some error. So, I could not proceed further. @kshitij-99 you can proceed with the same.
@kshitij-99
Copy link

@kshitij-99 kshitij-99 commented Aug 28, 2021

That's alright. I will picking this up now with a different account.
@kshitij-99
Copy link

@kshitij-99 kshitij-99 commented Aug 29, 2021

@faruktoptas opened PR #225. Kindly review and merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner feature-request first-timers-only good first issue
4 participants
@faruktoptas @HoussemNasri @kshitij-99 @Kritip123