Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGh 2290 view flags all edges all entities not cloned #2299
Merged
Conversation
…e sub-modules
…ssertEquals;' line and all now work
…tage junit5 dependency. Interim check-in. Up to accumulo-store
…-accumulo-library
…store-implementation/map-store and store-implementation/parquet-store
…eV1IT working when run with the other integration tests. However, it would run in isolation. Have added a TODO comment to find out why.
…nged back from junit5 -> 4. Tidied the code.
…fer project
… with develop. Lokking into why by finding the differences in the files
…disabled for the moment. Will merge the changes and open another ticket to look at these
…mvn -q flag. Will try with Travis debug settings to find out where it failed
…use. Made further changes to debug Travis
codecov-commenter
commented
Aug 5, 2020
•
Codecov Report
@@ Coverage Diff @@
## develop #2299 +/- ##
=============================================
- Coverage 67.70% 63.43% -4.28%
- Complexity 2082 2348 +266
=============================================
Files 788 930 +142
Lines 26872 31121 +4249
Branches 3287 3803 +516
=============================================
+ Hits 18195 19742 +1547
- Misses 7290 9789 +2499
- Partials 1387 1590 +203 Continue to review full report at Codecov.
|
|
See individual comments |
...a/src/main/java/uk/gov/gchq/gaffer/data/elementdefinition/view/View.java
Show resolved
Hide resolved
| @@ -433,6 +440,7 @@ public CHILD_CLASS globalElements(final GlobalViewElementDefinition... globalEle | |||
| return self(); | |||
| } | |||
|
|
|||
| @JsonSetter("globalEntities") | |||
This comment has been minimized.
This comment has been minimized.
d47853
Aug 6, 2020
Member
Are these annotations needed? Usually jackson uses the public setter methods. I may be wrong.
This comment has been minimized.
This comment has been minimized.
r32575
Aug 6, 2020
Author
Contributor
Removed all of the @JsonSetter methods as it was not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
r32575 commentedAug 4, 2020
The tests are now working and have been converted from junit 4 to 5 apart from the integration tests as changing them was more complex and could do with another task. Some of the unit tests have been disabled after failing with a lot of effort effort put it to correcting the problems. Another task will have to be raised to look into these further.
The original task to correct the View has also been fixed. It was when running maven after making the changes that problem above arose.