The Wayback Machine - https://web.archive.org/web/20220711010359/https://github.com/asyncapi/generator/issues/507
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance API docs with information about results of code generation with generateFromString using entrypoint #507

Open
derberg opened this issue Feb 10, 2021 · 12 comments
Labels
enhancement good first issue

Comments

@derberg
Copy link
Member

@derberg derberg commented Feb 10, 2021

Reason/Context

The problem is described here asyncapi-archived-repos/playground#79. It must be clear that returned data is not content but an object with content and metadata + what is this metadata, and that it is only with React renderer.

Description

Probably JSDoc must be only updated. Of course, some additional section in the readme would be also welcomed 😄

@derberg derberg added the enhancement label Feb 10, 2021
@jonaslagoni
Copy link
Sponsor Member

@jonaslagoni jonaslagoni commented Feb 10, 2021

Quick note it might actually not be a feature but a bug. Think the generateFromString should always return the content as is regardless of whether it is a Nunjucks or React template.

If it is the case remember to change the playground afterwards.

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 12, 2021

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Apr 12, 2021
@derberg derberg removed the stale label Apr 12, 2021
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 12, 2021

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 14, 2021

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Aug 14, 2021
@derberg derberg added good first issue and removed stale labels Aug 16, 2021
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 15, 2021

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Dec 15, 2021
@derberg derberg removed the stale label Dec 15, 2021
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 15, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Apr 15, 2022
@derberg derberg removed the stale label Apr 20, 2022
@derberg
Copy link
Member Author

@derberg derberg commented Apr 20, 2022

it is still valid, not JSDoc fix but bug fix but still easy to do.
No need to followup with playground as it is not used anymore

@starlightknown
Copy link

@starlightknown starlightknown commented Apr 27, 2022

Hi, I would like to take on this issue. A little guidance might be needed, I saw the playground PR and got some context.

@derberg
Copy link
Member Author

@derberg derberg commented May 9, 2022

I think it would be enough to just extend JSDoc of this function and explain that if entrypoint option is passed then the following object is returned => https://github.com/asyncapi/generator-react-sdk/blob/master/src/renderer/template.ts#L80

@magicmatatjahu @jonaslagoni thoughts?

@starlightknown did you edit JSDoc before? do you need support in explaining how to make changes locally and test if they work as expected?

@starlightknown
Copy link

@starlightknown starlightknown commented May 9, 2022

No, I haven't done it before and yes I'll need some help please

@derberg
Copy link
Member Author

@derberg derberg commented May 10, 2022

@starlightknown happy to help, no worries. Let's just make sure folks @magicmatatjahu @jonaslagoni agree with the fix that needs to be applied

@jonaslagoni
Copy link
Sponsor Member

@jonaslagoni jonaslagoni commented May 16, 2022

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
4 participants