The Wayback Machine - https://web.archive.org/web/20211018084620/https://github.com/storybookjs/storybook/issues/2762
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch mode on build-storybook? #2762

Closed
yjcxy12 opened this issue Jan 16, 2018 · 5 comments
Closed

Watch mode on build-storybook? #2762

yjcxy12 opened this issue Jan 16, 2018 · 5 comments
Labels
babel / webpack good first issue question / support

Comments

@yjcxy12
Copy link

@yjcxy12 yjcxy12 commented Jan 16, 2018

We are building storybook to integrate it into our existing Express app and using routing static server output of storybook to our route.

One thing is that looking at https://github.com/storybooks/storybook/blob/master/app/react/src/server/build.js#L74. It seems it doesn't support watch mode even if watch: true is passed in from webpack.config.js.

Would it be reasonable to run webpack().watch rather than webpack().run if watch: true is provided in webpack.config.js?
@Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Jan 27, 2018

What's your reason not to use webpack dev server with start-storybook command when developing?
@yjcxy12
Copy link
Author

@yjcxy12 yjcxy12 commented Jan 29, 2018 •
edited

We are exposing a route /storybook in our app for int and test environment, so that non-devs can access the storybook page.

We can develop locally using start-storybook and only use build-storybook in our CI, but then locally we have to run build-storybook to check/storybook endpoint is rending correctly after developing locally. An option to utilise webpack's watch mode on build-storybook would be nice.
@Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Jan 29, 2018

OK I think I got your point. Want to send a PR?
@yjcxy12
Copy link
Author

@yjcxy12 yjcxy12 commented Jan 29, 2018

Sure will do.
@yjcxy12 yjcxy12 mentioned this issue Jan 29, 2018
Merged
@igor-dv igor-dv added the merged label Jan 31, 2018
@Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Feb 3, 2018

Released as 3.4.0-alpha.7
@Hypnosphi Hypnosphi closed this Feb 3, 2018
@igor-dv igor-dv mentioned this issue Nov 29, 2018
Merged
@dependencies dependencies bot mentioned this issue Jan 15, 2021
Merged
@saulrobe saulrobe mentioned this issue Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
babel / webpack good first issue question / support
3 participants
@Hypnosphi @yjcxy12 @igor-dv