The Wayback Machine - https://web.archive.org/web/20210904102327/https://github.com/twbs/bootstrap/pull/33399
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.browserslistrc: remove Android and make Safari/iOS 12 the minimum #33399

Merged
merged 1 commit into from Mar 22, 2021

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 18, 2021

This will result in more modern JS dist files, and saves us a good amount of bytes. This was the plan in #30986, but I gave up after the Safari 10 failures back then.

Apart from terser which we use, I tested the latest uglify-js and seems to work fine too.

Closes #31153.

/CC @alpadev @RyanBerliner @GeoSot @Johann-S @rohit2sharma95 @mdo

Preview: https://deploy-preview-33399--twbs-bootstrap.netlify.app/

TODO:

  • Adapt bundlewatch limits
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta3 via automation Mar 18, 2021
@XhmikosR XhmikosR marked this pull request as ready for review Mar 18, 2021
@XhmikosR XhmikosR requested a review from twbs/js-review as a code owner Mar 18, 2021
@XhmikosR XhmikosR marked this pull request as draft Mar 18, 2021
@XhmikosR XhmikosR marked this pull request as ready for review Mar 18, 2021
@XhmikosR XhmikosR force-pushed the main-xmr-browserslist-safari branch from cc84bb5 to 22cd629 Mar 18, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0-beta3 Mar 18, 2021
@mdo
mdo approved these changes Mar 22, 2021
v5.0.0-beta3 automation moved this from Review to Approved Mar 22, 2021
@mdo mdo added this to Inbox in v5.0.0 via automation Mar 22, 2021
@mdo mdo removed this from Approved in v5.0.0-beta3 Mar 22, 2021
v5.0.0 automation moved this from Inbox to Approved Mar 22, 2021
@GeoSot
GeoSot approved these changes Mar 22, 2021
@XhmikosR XhmikosR removed this from Approved in v5.0.0 Mar 22, 2021
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta3 via automation Mar 22, 2021
@XhmikosR XhmikosR moved this from Inbox to Approved in v5.0.0-beta3 Mar 22, 2021
@XhmikosR XhmikosR merged commit d9da43f into main Mar 22, 2021
23 checks passed
23 checks passed
@github-actions
browserstack
Details
@github-actions
bundlewatch
Details
@github-actions
bundlewatch
Details
@github-actions
Analyze
Details
@github-actions
docs
Details
@github-actions
docs
Details
@github-actions
Node 10
Details
@github-actions
Node 10
Details
@github-actions
lint
Details
@github-actions
lint
Details
@github-actions
Node 12
Details
@github-actions
Node 12
Details
@github-actions
Node 14
Details
@github-actions
Node 14
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
@lgtm-com
LGTM analysis: JavaScript No new or fixed alerts
Details
bundlewatch Everything is in check (+0B, -9.66KB, -4.1%)
Details
coverage/coveralls Coverage decreased (-0.03%) to 94.706%
Details
deploy/netlify Deploy preview ready!
Details
v5.0.0-beta3 automation moved this from Approved to Done Mar 22, 2021
@XhmikosR XhmikosR deleted the main-xmr-browserslist-safari branch Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants