The Wayback Machine - https://web.archive.org/web/20210904102452/https://github.com/twbs/bootstrap/pull/32756
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint: disallow some property values #32756

Merged
merged 2 commits into from Jan 13, 2021
Merged

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 11, 2021

  • border: none
  • outline: none

Refs #32751

@XhmikosR XhmikosR added the build label Jan 11, 2021
* border: none
* outline: none
@XhmikosR XhmikosR force-pushed the main-xmr-stylelint-disallowed branch from c3fbf04 to 2144539 Jan 11, 2021
@ffoodd
ffoodd approved these changes Jan 11, 2021
Copy link
Member

@ffoodd ffoodd left a comment

Nice idea 👍

@XhmikosR XhmikosR requested a review from mdo Jan 11, 2021
@XhmikosR
Copy link
Member Author

@XhmikosR XhmikosR commented Jan 11, 2021

Not sure if we should backport this, but doing so means we'll have to change any none values.

@mdo your call

@XhmikosR XhmikosR marked this pull request as ready for review Jan 12, 2021
@XhmikosR XhmikosR added this to Inbox in v4.6.0 via automation Jan 12, 2021
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Jan 12, 2021
@XhmikosR
Copy link
Member Author

@XhmikosR XhmikosR commented Jan 12, 2021

Actually, it seems the related patches have been backported in #32748 so I guess it makes sense to include this in v4.6.0 too?

v5.0.0-beta2 automation moved this from Inbox to Approved Jan 13, 2021
@mdo
mdo approved these changes Jan 13, 2021
@XhmikosR XhmikosR merged commit ed5ddca into main Jan 13, 2021
23 checks passed
23 checks passed
@github-actions
browserstack
Details
@github-actions
bundlewatch
Details
@github-actions
bundlewatch
Details
@github-actions
Analyze
Details
@github-actions
docs
Details
@github-actions
docs
Details
@github-actions
Node 10
Details
@github-actions
Node 10
Details
@github-actions
lint
Details
@github-actions
lint
Details
@github-actions
Node 12
Details
@github-actions
Node 12
Details
@github-actions
Node 14
Details
@github-actions
Node 14
Details
@lgtm-com
LGTM analysis: JavaScript No code changes detected
Details
@github-code-scanning
CodeQL No new alerts
Details
bundlewatch Everything is in check (+0B, -0B, ±0.0%)
Details
coverage/coveralls Coverage remained the same at 94.358%
Details
deploy/netlify Deploy preview ready!
Details
v5.0.0-beta2 automation moved this from Approved to Done Jan 13, 2021
@XhmikosR XhmikosR deleted the main-xmr-stylelint-disallowed branch Jan 13, 2021
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked/Manually backported in v4.6.0 Jan 13, 2021
XhmikosR added a commit that referenced this pull request Jan 13, 2021
* `border: none`
* `outline: none`
XhmikosR added a commit that referenced this pull request Jan 13, 2021
* `border: none`
* `outline: none`
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Jan 13, 2021
GeoSot added a commit to GeoSot/bootstrap that referenced this pull request Jan 21, 2021
GeoSot added a commit to GeoSot/bootstrap that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants