Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add algorithm for N-body simulation - retry #4298
Add algorithm for N-body simulation - retry #4298
Changes from all commits
97f9f6c1812626719c628d375b7456e1dc409237cb3093f527a0081d790277e9bfafa6c063ff3b6059772612bcb0368d9cFile filter
Conversations
Jump to
algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionpositionalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionpositionalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionpositionalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionpositionalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionvelocityalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionvelocityalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionvelocityalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionvelocitycclaussApr 4, 2021
Member
Suggested change
def update_velocity(
@property
def position(self) tuple[float, float]:
return self.position_x, self.position_y
@property
def velocity(self) tuple[float, float]:
return self.position_x, self.position_y
def update_velocity(
algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the function__len__algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the function__len__algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the function__len__cclaussApr 4, 2021
Member
Suggested change
def update_system(self, delta_time: float) -> None:
def __len__() -> int:
return len(self.bodies)
def update_system(self, delta_time: float) -> None:
cclaussApr 4, 2021
Member
Suggested change
>>> body_system_1.update_system(1)
>>> len(body_system_1)
2
>>> body_system_1.update_system(1)
algorithms-keeper botMar 29, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botMar 29, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botMar 29, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botMar 29, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionplotalgorithms-keeper botMar 29, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionupdatealgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionupdatealgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionupdatealgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionupdatealgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionupdatealgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionupdatealgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionupdatealgorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_2algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_2algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_2algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_2algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_3algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_3algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_3algorithms-keeper botApr 4, 2021
As there is no test file in this pull request nor any test function or class in the file
physics/n_body_simulation.py, please provide doctest for the functionexample_3