The Wayback Machine - https://web.archive.org/web/20210906161300/https://github.com/TheAlgorithms/Python/pull/4702
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy fix for functions in maths #4702

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Mypy fix for functions in maths #4702

wants to merge 9 commits into from

Conversation

@IanAuckes
Copy link

@IanAuckes IanAuckes commented Aug 31, 2021

Describe your change:

Corrected p_series.py and geometric_series.py in maths/series folder for mypy.
Related Issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
IanAuckes added 3 commits Aug 31, 2021
@IanAuckes
mypy fix for geometric_series.py and p_series.py in maths/series/
13f628c
@IanAuckes
Merge branch 'TheAlgorithms:master' into mypy-fix-maths-series
07cae88
@IanAuckes
updated doctest for p_series and geometric_series in maths/series/
1317fbc
@IanAuckes IanAuckes requested a review from Kush1101 as a code owner Aug 31, 2021
@cclauss
cclauss reviewed Aug 31, 2021
View changes
maths/series/geometric_series.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Aug 31, 2021
View changes
maths/series/geometric_series.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Aug 31, 2021
View changes
maths/series/p_series.py Outdated Show resolved Hide resolved
@IanAuckes
updated code as stated in review
99919b1
@cclauss
Copy link
Member

@cclauss cclauss commented Aug 31, 2021

Rewriting these functions to be more complicated just to comply with mypy seems to be a stretch.
@IanAuckes
Copy link
Author

@IanAuckes IanAuckes commented Aug 31, 2021 •
edited

The functions themselves weren't rewritten. Just type checks were added.

Majority of the change was in the means to make the code run with live user inputs (outside of the function definition).
We could drop the live input support to simplify the code (as is the case for other functions in this directory)
IanAuckes added 4 commits Aug 31, 2021
@IanAuckes
updated code as stated in review
24f2d6e
@IanAuckes
Merge branch 'TheAlgorithms:master' into mypy-fix-maths-series
568c3f2
@IanAuckes
mypy fix for maths. minor change in average_mode.py
488ba76
@IanAuckes
Merge branch 'mypy-fix-maths-series' of https://github.com/IanAuckes/…
558bd3f 
…Python into mypy-fix-maths-series
@IanAuckes
Copy link
Author

@IanAuckes IanAuckes commented Aug 31, 2021

The last commit completes all the functions in the directory maths (including sub-directories).
If this pull request is merged, I'd recommend changing the checkbox for maths in #4052
@cclauss
cclauss reviewed Aug 31, 2021
View changes
maths/average_mode.py Outdated Show resolved Hide resolved
@IanAuckes @cclauss
Update maths/average_mode.py
a8dd73d 
simplify the code

Co-authored-by: Christian Clauss <[email protected]>
@IanAuckes IanAuckes changed the title Mypy fix for 2 functions Mypy fix for functions in maths Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews enhancement
2 participants
@IanAuckes @cclauss