The Wayback Machine - https://web.archive.org/web/20210908061737/https://github.com/TheAlgorithms/Python/pull/4686
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added unbounded knapsack #4686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added unbounded knapsack #4686

wants to merge 1 commit into from

Conversation

@likileads
Copy link

@likileads likileads commented Aug 28, 2021

Unbounded knapsack is much similar to 0/1 knapsack.
But, in unbounded knapsack repetition of item is allowed (that is, we can pick the same item more than one time).
This is not the case in 0/1 knapsack, where we have choice to pick or not pick the item, and one item can be picked only once.

The main idea of this algorithm is to maximize the total profit by picking all the items that fits into total capacity of the bag.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@likileads
added unbounded knapsack
aa38bdd 
Unbounded knapsack is much similar to 0/1 knapsack.
But, in unbounded knapsack repetition of item is allowed (that is, we can pick the same item more than one time).
This is not the case in 0/1 knapsack, where we have choice to pick or not pick the item, and one item can be picked only once.

The main idea of this algorithm is to maximize the total profit by picking all the items that fits into total capacity of the bag.
@algorithms-keeper
algorithms-keeper bot reviewed Aug 28, 2021
View changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
knapsack/unbounded_knapsack.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews require descriptive names tests are failing
1 participant
@likileads