The Wayback Machine - https://web.archive.org/web/20210831162041/https://github.com/TheAlgorithms/Python/pull/4673
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] unused variable, standalone running, import doctest module #4673

Merged
merged 11 commits into from Aug 28, 2021
Merged

[fixed] unused variable, standalone running, import doctest module #4673

merged 11 commits into from Aug 28, 2021

Conversation

@slowy07
Copy link
Contributor

@slowy07 slowy07 commented Aug 26, 2021 •
edited

Describe your change:

fixed unused variable, and using if __name__ == "__main__", and imported doctest module for following style code

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@slowy07
[fixed] unused variable, standalone running, import doctest module
b405b34 
information [standalone running](https://www.geeksforgeeks.org/what-does-the-if-__name__-__main__-do/)

Signed-off-by: slowy07 <[email protected]>
@cclauss
cclauss requested changes Aug 27, 2021
View changes
matrix/spiral_print.py Outdated Show resolved Hide resolved
other/fischer_yates_shuffle.py Outdated Show resolved Hide resolved
@slowy07 @cclauss
Update other/fischer_yates_shuffle.py
7bb2410 
Co-authored-by: Christian Clauss <[email protected]>
@slowy07
[fixed] change to tuple and fixing callfunction
ffdd4aa 
Signed-off-by: slowy07 <[email protected]>
@slowy07 slowy07 requested a review from cclauss Aug 28, 2021
@cclauss
cclauss requested changes Aug 28, 2021
View changes
matrix/spiral_print.py Show resolved Hide resolved
matrix/spiral_print.py Outdated Show resolved Hide resolved
matrix/spiral_print.py Outdated Show resolved Hide resolved
@slowy07 @cclauss
Update matrix/spiral_print.py
ef3ea0e 
Co-authored-by: Christian Clauss <[email protected]>
@slowy07 @cclauss
Update matrix/spiral_print.py
e6527ab 
Co-authored-by: Christian Clauss <[email protected]>
@slowy07 @cclauss
fixing
aa556b8 
Co-authored-by: Christian Clauss <[email protected]>
@cclauss
cclauss reviewed Aug 28, 2021
View changes
matrix/spiral_print.py Outdated Show resolved Hide resolved
@slowy07
[fixed] sprial matrix
8fc1402 
Signed-off-by: slowy07 <[email protected]>
@slowy07 slowy07 requested a review from cclauss Aug 28, 2021
@cclauss
Update spiral_print.py
cd8cf0d
cclauss added 2 commits Aug 28, 2021
@cclauss
Update spiral_print.py
422a798
@cclauss
Update spiral_print.py
a65bce5
@cclauss
Update spiral_print.py
b451253
@cclauss
cclauss approved these changes Aug 28, 2021
View changes
@cclauss cclauss merged commit 8e5c353 into TheAlgorithms:master Aug 28, 2021
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
2 participants
@slowy07 @cclauss