The Wayback Machine - https://web.archive.org/web/20220520165032/https://github.com/tensorflow/agents/issues/554
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 1: Train a Deep Q Network with TF-Agents and the use of a driver #554

Open
jan-polivka opened this issue Feb 10, 2021 · 1 comment
Open

Comments

@jan-polivka
Copy link

@jan-polivka jan-polivka commented Feb 10, 2021

Hello,

I believe the tutorial 1_dqn_tutorial.ipynb has an unnecessary import of dynamic_step_driver. The module is not used at all, so the scripts runs just fine when commented out. Furthermore, I think it would be nice if the Data Collecting section explicitly talked about tutorial 4 and that this pattern is called a Driver. It is already somewhat alluding to it:

# This loop is so common in RL, that we provide standard implementations. 
# For more details see the drivers module.
# https://www.tensorflow.org/agents/api_docs/python/tf_agents/drivers

Since the tutorial on Drivers exists, it seems very handy to me to use it. Something like this:

# This loop is very common in RL, we call it a "Driver" and we provide standard implementations. 
# For more details see the tutorial 4 or the drivers module
# https://github.com/tensorflow/agents/blob/master/docs/tutorials/4_drivers_tutorial.ipynb
# https://www.tensorflow.org/agents/api_docs/python/tf_agents/drivers

It's a very minor issue but I think it's a good idea to make it simpler for learners. It would have helped me.

@jan-polivka jan-polivka changed the title 1_dqn_tutorial.ipynb and the use of a driver Tutorial 1: Train a Deep Q Network with TF-Agents and the use of a driver Feb 10, 2021
@ebrevdo
Copy link
Collaborator

@ebrevdo ebrevdo commented Mar 18, 2021

Thanks! We'd love for you to submit a PR cleaning this up! It makes a great beginner contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants