The Wayback Machine - https://web.archive.org/web/20201028011319/https://github.com/angular-fullstack/generator-angular-fullstack/pull/2750
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): Update to sequelize 4 #2750

Merged
merged 1 commit into from Jul 24, 2018
Merged

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Jul 22, 2018

Update sequelize to v4 and fix the user model to work with this.

Part of #2691

@zeripath zeripath force-pushed the zeripath:issue-2691 branch from 4a07111 to a5a8aae Jul 22, 2018
@zeripath zeripath mentioned this pull request Jul 22, 2018
3 of 3 tasks complete
@zeripath zeripath force-pushed the zeripath:issue-2691 branch from a5a8aae to d98b24d Jul 22, 2018
});
});
beforeBulkCreate(users, fields) {
return sequelize.Promise.map(users, user => user.updatePassword());

This comment has been minimized.

@Awk34

Awk34 Jul 23, 2018
Member

Does this not work if you just use the global Promise built into Node?

* @api public
*/
User.prototype.updatePassword = function() {
var user = this;

This comment has been minimized.

@Awk34

Awk34 Jul 23, 2018
Member

The alias for this seems unnecessary here

Update sequelize to v4 and fix the user model to work with this.

Part of #2691
@zeripath zeripath force-pushed the zeripath:issue-2691 branch from 9c44d7b to 02f0385 Jul 24, 2018
@Awk34
Awk34 approved these changes Jul 24, 2018
@Awk34 Awk34 merged commit 1a3ba73 into angular-fullstack:master Jul 24, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@zeripath zeripath deleted the zeripath:issue-2691 branch Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.