The Wayback Machine - https://web.archive.org/web/20211010065928/https://github.com/facebook/react/issues/22152
Skip to content

/ react Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blocks Fixture] Migrate to built-in <Cache> API and regression test #22152

Open
3 tasks
ryota-murakami opened this issue Aug 21, 2021 · 16 comments
Open
3 tasks

[Blocks Fixture] Migrate to built-in <Cache> API and regression test #22152

ryota-murakami opened this issue Aug 21, 2021 · 16 comments
Labels
good first issue

Comments

@ryota-murakami
Copy link
Contributor

@ryota-murakami ryota-murakami commented Aug 21, 2021

Summary

This is task list issue.
"Blocks" fixture app which made by built-in API, 'react-fetch', Server Component combination that useful to play new features v18 later.

But current one is broken because importing removed older Cache API module.
And difficult to notice that regression because there are no tests.

So I planning these task for Blocks working fine again and write regression tests.

  • #22151
  • Write regression tests with Cypress
  • Consider better implementation at some @TODO comments, where should we invoke cache refresh() function etc...

Screen Capture

Screen.Recording.2021-08-22.at.4.17.49.mov
@ryota-murakami ryota-murakami mentioned this issue Aug 21, 2021
Open
@vishal5251
Copy link

@vishal5251 vishal5251 commented Aug 23, 2021

I want to work on this issue could you please explain a bit more about this issue.
@SaNsK11
Copy link

@SaNsK11 SaNsK11 commented Aug 26, 2021

@ryota-murakami I'd like to contribute
/assign
@juank1809
Copy link

@juank1809 juank1809 commented Aug 26, 2021

I'd like to contribute as well :)
@apollofps
Copy link

@apollofps apollofps commented Aug 27, 2021

i have a technical assesment for internship .Id like to contribute to this as well
@Akshat1331
Copy link

@Akshat1331 Akshat1331 commented Aug 27, 2021

can i contribute to this too as i am a beginner as it will be my first contribution to an open source project can anyone help me?
@eps1lon eps1lon mentioned this issue Aug 27, 2021
Closed
@tejadasari985 tejadasari985 mentioned this issue Aug 27, 2021
Closed
@Subhojit-Dey1234
Copy link

@Subhojit-Dey1234 Subhojit-Dey1234 commented Aug 28, 2021 •
edited

Can anyone help? I am new to open-source projects. How can I start?
@ryota-murakami
Copy link
Contributor Author

@ryota-murakami ryota-murakami commented Aug 29, 2021

Thank you for forks who has interest about this issue.
Actually, the "Good to First Issue" label is attached by @bvaughn however this [Blocks Fixture] part original author is @gaearon.

Therefore we have to wait to take up bellow first PR review,

And confirm Dan to how about my regression test plan with Cypress.
So waiting is only option now until get response Dan or other core team's guy review.
@aniruddhapw
Copy link

@aniruddhapw aniruddhapw commented Aug 30, 2021

I would like to contribute
@Harshvardhan1999
Copy link

@Harshvardhan1999 Harshvardhan1999 commented Aug 31, 2021

I would love to contribute
@FlashStar09
Copy link

@FlashStar09 FlashStar09 commented Aug 31, 2021

I want to contribute here!
@pawan43563
Copy link

@pawan43563 pawan43563 commented Sep 3, 2021

I would love to contribute
@yash431garg
Copy link

@yash431garg yash431garg commented Sep 4, 2021

I can help you in that would love to contribute
@Lis27ha
Copy link

@Lis27ha Lis27ha commented Sep 4, 2021

I would love to contribute as well
@tarzan114
Copy link

@tarzan114 tarzan114 commented Sep 8, 2021

Hi i'd love to contribute as well
@anushaNemilidinne
Copy link

@anushaNemilidinne anushaNemilidinne commented Sep 11, 2021

Hello! This will be my first contribution to open source projects. Can I contribute?
@Voloda56
Copy link

@Voloda56 Voloda56 commented Oct 2, 2021

Я тоже хочу внесты внесок?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue