The Wayback Machine - https://web.archive.org/web/20210730084829/https://github.com/sharkdp/bat/issues/1733
Skip to content

/ bat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bash completion files to Debian packages #1733

Open
sharkdp opened this issue Jul 14, 2021 · 0 comments · May be fixed by #1734
Open

Add bash completion files to Debian packages #1733

sharkdp opened this issue Jul 14, 2021 · 0 comments · May be fixed by #1734
Labels
good first issue packaging/tooling

Comments

@sharkdp
Copy link
Owner

@sharkdp sharkdp commented Jul 14, 2021

Follow the same route as for the fish/zsh completions in .github/workflows/CICD.yml.
@sharkdp sharkdp mentioned this issue Jul 14, 2021
Merged
scop added a commit to scop/bat that referenced this issue Jul 15, 2021
@scop
Include bash completion in deb package
9bf0607 
Get correct path to install in from bash-completion using pkgconf,
install as env.PROJECT_EXECUTABLE as the filename needs to match the
called executable for bash-completion's on demand loading to work.

Closes sharkdp#1733
@scop scop linked a pull request that will close this issue Jul 15, 2021
Open
scop added a commit to scop/bat that referenced this issue Jul 15, 2021
@scop
Include bash completion in deb package
dba78b9 
Get correct path to install in from bash-completion using
`pkg-config`, install as `env.PROJECT_EXECUTABLE` as the filename
needs to match the called executable for bash-completion's on demand
loading to work.

Closes sharkdp#1733
scop added a commit to scop/bat that referenced this issue Jul 15, 2021
@scop
Include bash completion in deb package
07a3b00 
Get correct path to install in from bash-completion using
`pkg-config`, install as `steps.strip.outputs.BIN_NAME` as the filename
needs to match the called executable for bash-completion's on demand
loading to work.

This `BIN_NAME` needs to stay in sync with `env.PROJECT_EXECUTABLE`
which is replaced in the template, but not available for the deb build
at this stage.

Closes sharkdp#1733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue packaging/tooling
1 participant
@sharkdp