The Wayback Machine - https://web.archive.org/web/20211118163838/https://github.com/SeldonIO/seldon-core/issues/2913
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all references to contract.json in examples #2913

Open
axsaucedo opened this issue Feb 1, 2021 — with Board Genius Sync · 2 comments
Open

Remove all references to contract.json in examples #2913

axsaucedo opened this issue Feb 1, 2021 — with Board Genius Sync · 2 comments
Labels
good first issue
Projects
Backlog

Comments

@axsaucedo Board Genius Sync
Copy link
Member

@axsaucedo axsaucedo commented Feb 1, 2021 — with Board Genius Sync

The contract.json is no longer the standard way to show how to interact with models, and there were initial efforts to update most examples to reflect the more comon ways of interacting with the deployed seldon models. There are still however a handful of examples that still use the contract.json approach, so this issue will just require updating the remaining examples to work using the seldon python client directly (or using curl)
@omerfsen
Copy link
Contributor

@omerfsen omerfsen commented Feb 1, 2021

What do we use instead of contract.json? For example R model examples still uses it.
@axsaucedo
Copy link
Member Author

@axsaucedo axsaucedo commented Feb 1, 2021 •
edited
Loading

@omerfsen this was actually in context of the R example, as a user was confused trying to send the request as it currently is in the contract.json.

For the iris R example you would just use a normal curl like:

curl -v -X POST -H 'Content-Type: application/json' \\\n",
    -d '{"data": {"ndarray": [[0,1,2,3]], "names": ["sepal_length", "sepal_width", "petal_length", "petal_width"] }}'",
    http://localhost:80/seldon/default/seldon-deployment-example/api/v1.0/predictions"
@cliveseldon cliveseldon added this to Triage in Backlog via automation Feb 11, 2021
@cliveseldon cliveseldon moved this from Triage to Backlog in Backlog Feb 25, 2021
@axsaucedo axsaucedo changed the title Remove all references to contract.json in examples OSS-197: Remove all references to contract.json in examples Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-197: Remove all references to contract.json in examples Remove all references to contract.json in examples Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
4 participants
@axsaucedo @cliveseldon @RafalSkolasinski @omerfsen