The Wayback Machine - https://web.archive.org/web/20210820234859/https://github.com/facebook/react/pull/21897
Skip to content

/ react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Import scheduling profiler into DevTools Profiler #21897

Merged
merged 1 commit into from Jul 22, 2021
Merged

[DRAFT] Import scheduling profiler into DevTools Profiler #21897

merged 1 commit into from Jul 22, 2021
+931 −1,128

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 16, 2021 •
edited

Related to #21866; alternate for #19892.

  • Import scheduling profiler into Profiler tab
  • Disable Vercel deploy script for old standalone scheduling profiler
  • Hide right panel when scheduling profiler is open (more horizontal space)
  • Make sure new profiler colors have light and dark theme variants
  • Switching theme should update the colors and re-render the canvas
  • Make import/export buttons in Profiler depend on the selected tab (so you can impor more than one scheduling profile)
  • Canvas tooltips should not be visible while context menu is shown.
  • Add usage instructions
  • Only enable Scheduling tab for Chrome
  • Update dynamic height calculation for two canvas sections to account for shorter extensions height
@bvaughn bvaughn changed the title Import scheduling profiler into DevTools Profiler tab [DRAFT] Import scheduling profiler into DevTools Profiler Jul 16, 2021
@sizebot
Copy link

@sizebot sizebot commented Jul 16, 2021 •
edited

Comparing: 25f09e3...ab1efcf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.40 kB 127.40 kB = 40.74 kB 40.74 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.22 kB 130.22 kB = 41.66 kB 41.66 kB
facebook-www/ReactDOM-prod.classic.js = 407.20 kB 407.20 kB = 75.13 kB 75.13 kB
facebook-www/ReactDOM-prod.modern.js = 395.90 kB 395.90 kB = 73.40 kB 73.40 kB
facebook-www/ReactDOMForked-prod.classic.js = 407.20 kB 407.20 kB = 75.13 kB 75.13 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ab1efcf

@bvaughn bvaughn force-pushed the bvaughn:devtools-scheduling-profiler branch from a118800 to 7dd57d3 Jul 16, 2021
@bvaughn bvaughn force-pushed the bvaughn:devtools-scheduling-profiler branch from 7dd57d3 to acd1f89 Jul 19, 2021
@bvaughn bvaughn mentioned this pull request Jul 19, 2021
Closed
2 tasks
@bvaughn bvaughn force-pushed the bvaughn:devtools-scheduling-profiler branch from acd1f89 to dd7d036 Jul 20, 2021
This was referenced Jul 20, 2021
Open
Merged
@bvaughn bvaughn force-pushed the bvaughn:devtools-scheduling-profiler branch 5 times, most recently from 4d6376a to 87cff5f Jul 20, 2021
@bvaughn
Import scheduling profiler into DevTools Profiler tab
ab1efcf
@bvaughn bvaughn force-pushed the bvaughn:devtools-scheduling-profiler branch from 87cff5f to ab1efcf Jul 22, 2021
@bvaughn bvaughn marked this pull request as ready for review Jul 22, 2021
@bvaughn bvaughn merged commit f4161c3 into facebook:main Jul 22, 2021
18 of 24 checks passed
18 of 24 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_build CircleCI is running your tests
Details
ci/circleci: yarn_build CircleCI is running your tests
Details
ci/circleci: yarn_build_combined CircleCI is running your tests
Details
ci/circleci: yarn_flow CircleCI is running your tests
Details
ci/circleci: yarn_test--r=stable --env=development CircleCI is running your tests
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=true CircleCI is running your tests
Details
@facebook-github-tools
Facebook CLA Check Contributor License Agreement is valid!
Details
ci/circleci: get_base_build Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sync_reconciler_forks Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=experimental --env=development Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=experimental --env=development --persistent Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=experimental --env=production Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=stable --env=development --persistent Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=stable --env=production Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=false Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=true Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=false Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=true Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=false Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=true Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=false Your tests passed on CircleCI!
Details
@codesandbox
ci/codesandbox Building packages succeeded.
Details
@bvaughn bvaughn deleted the bvaughn:devtools-scheduling-profiler branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Component: Developer Tools React Core Team
3 participants
@bvaughn @sizebot @facebook-github-bot