The Wayback Machine - https://web.archive.org/web/20220510135800/https://github.com/hacs/default/pull/1037
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new integration [basnijholt/adaptive-lighting] #1037

Merged
merged 2 commits into from Aug 15, 2021

Conversation

Copy link
Contributor

@RubenKelevra RubenKelevra commented Aug 1, 2021

This is a successor to #671, which was declined due to the open PR for adding adaptive-lighting as a core component. Since this PR was withdrawn I think it's fine to add it to the hacs default repositories.

@hacs-bot hacs-bot bot changed the title add adaptive-lighting integration Adds new integration [basnijholt/adaptive-lighting] Aug 1, 2021
@hacs-bot
Copy link

@hacs-bot hacs-bot bot commented Aug 1, 2021

Running checks on basnijholt/adaptive-lighting

@ludeeus
Copy link

@ludeeus ludeeus commented Aug 1, 2021

You are not the owner and your contributions to that repo are not considered major, it's great that you want to help out but I can't accept this PR from you

https://hacs.xyz/docs/publish/include

Only the owner of the repository or a major contributor to it can submit a PR to have it included as a default.

@ludeeus ludeeus closed this Aug 1, 2021
@RubenKelevra
Copy link
Author

@RubenKelevra RubenKelevra commented Aug 4, 2021

@basnijholt can you please approve this PR :)

Copy link
Contributor

@basnijholt basnijholt left a comment

Thanks a lot for doing this!

@basnijholt
Copy link

@basnijholt basnijholt commented Aug 5, 2021

@ludeeus could you reopen this PR?

@jbouwh jbouwh reopened this Aug 5, 2021
@hacs-bot hacs-bot bot changed the title Adds new integration [basnijholt/adaptive-lighting] Adds new integration [shbatm/hacs-isy994] Aug 5, 2021
@hacs-bot
Copy link

@hacs-bot hacs-bot bot commented Aug 5, 2021

Running checks on shbatm/hacs-isy994

@jbouwh
Copy link

@jbouwh jbouwh commented Aug 5, 2021

need to rebase

jbouwh
jbouwh previously approved these changes Aug 5, 2021
Copy link
Contributor

@jbouwh jbouwh left a comment

The owner is not an issue

@hacs-bot hacs-bot bot changed the title Adds new integration [shbatm/hacs-isy994] Adds new integration [basnijholt/adaptive-lighting] Aug 6, 2021
@hacs-bot
Copy link

@hacs-bot hacs-bot bot commented Aug 6, 2021

Running checks on basnijholt/adaptive-lighting

@RubenKelevra
Copy link
Author

@RubenKelevra RubenKelevra commented Aug 6, 2021

@jbouwh wrote:

need to rebase

done

@RubenKelevra RubenKelevra requested a review from jbouwh Aug 6, 2021
@RubenKelevra
Copy link
Author

@RubenKelevra RubenKelevra commented Aug 9, 2021

@ludeeus can you have another look, please? :)

@ludeeus ludeeus merged commit 6ac1e22 into hacs:master Aug 15, 2021
6 of 7 checks passed
@hacs-bot
Copy link

@hacs-bot hacs-bot bot commented Aug 15, 2021

Your repository is now added to HACS 🎉

Here is a few resources that can be useful:

@RubenKelevra RubenKelevra deleted the patch-8 branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment