The Wayback Machine - https://web.archive.org/web/20220510073955/https://github.com/swift-project/pilotclient/issues/107
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unknown aircraft ICAO code in flightplan #107

Closed
oktal3700 opened this issue Apr 11, 2021 · 0 comments
Closed

Allow unknown aircraft ICAO code in flightplan #107

oktal3700 opened this issue Apr 11, 2021 · 0 comments
Assignees
Labels
bug good first issue UX

Comments

@oktal3700
Copy link

@oktal3700 oktal3700 commented Apr 11, 2021

If the flightplan GUI contains an aircraft ICAO code that is not in the DB, then an empty ICAO code will be sent to the network. This is a problem because there are legitimate reasons why a user might want to use a code that is not "real world". There is already a warning message for the user to confirm whether the unknown code is a mistake or not.

The problem is CFlightPlanComponent::getAircraftIcaoCode. Either this function should be made more permissive, or validateAndInitializeFlightPlan should avoid calling that function and instead get the ICAO code directly from the QLineEdit *le_AircraftType. It's not immediately clear to me which of these would be the more correct fix.

@oktal3700 oktal3700 added bug good first issue UX labels Apr 11, 2021
@oktal3700 oktal3700 self-assigned this Jul 29, 2021
@oktal3700 oktal3700 closed this Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue UX
1 participant