The Wayback Machine - https://web.archive.org/web/20220410032158/https://github.com/microsoft/vscode/pull/22369
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle proxy authentication #22369

Merged
merged 7 commits into from Jul 3, 2017
Merged

Handle proxy authentication #22369

merged 7 commits into from Jul 3, 2017

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Mar 10, 2017

This PR makes Code handle the app.on('listen' event from Electron, thus supporting proxy authentication.

image
@joaomoreno joaomoreno added feature-request proxy labels Mar 10, 2017
@joaomoreno joaomoreno added this to the March 2017 milestone Mar 10, 2017
@joaomoreno joaomoreno self-assigned this Mar 10, 2017
@joaomoreno joaomoreno mentioned this pull request Mar 10, 2017
Closed
@joaomoreno joaomoreno removed this from the March 2017 milestone Mar 30, 2017
@joaomoreno joaomoreno added this to the April 2017 milestone Mar 30, 2017
@joaomoreno joaomoreno added this to the April 2017 milestone Mar 30, 2017
@joaomoreno joaomoreno removed this from the March 2017 milestone Mar 30, 2017
@joaomoreno joaomoreno removed this from the April 2017 milestone Apr 24, 2017
@joaomoreno joaomoreno added this to the May 2017 milestone Apr 24, 2017
@joaomoreno joaomoreno added this to the May 2017 milestone Apr 24, 2017
@joaomoreno joaomoreno removed this from the April 2017 milestone Apr 24, 2017
@joaomoreno joaomoreno mentioned this pull request May 5, 2017
Closed
@rajasimon rajasimon mentioned this pull request May 18, 2017
Closed
@joaomoreno joaomoreno removed this from the May 2017 milestone May 24, 2017
@joaomoreno joaomoreno added this to the June 2017 milestone May 24, 2017
@joaomoreno joaomoreno added this to the June 2017 milestone May 24, 2017
@joaomoreno joaomoreno removed this from the May 2017 milestone May 24, 2017
@arek20
Copy link

@arek20 arek20 commented Jun 5, 2017

Any progress on that or ETA when it will be merged. I really need access from behind the authenticated corporate proxy. Thank you!
@joaomoreno joaomoreno mentioned this pull request Jun 14, 2017
Closed
@joaomoreno joaomoreno added this to the July 2017 milestone Jun 26, 2017
@joaomoreno joaomoreno removed this from the June 2017 milestone Jun 26, 2017
@joaomoreno joaomoreno merged commit a4667bf into microsoft:master Jul 3, 2017
1 of 2 checks passed
@joaomoreno joaomoreno deleted the proxy-auth branch Jul 3, 2017
@joaomoreno joaomoreno mentioned this pull request Jul 3, 2017
Closed
@joaomoreno joaomoreno mentioned this pull request Jul 3, 2017
Closed
@joaomoreno joaomoreno mentioned this pull request Jul 3, 2017
Closed
@weinand weinand added the verification-needed label Jul 27, 2017
@ninrod
Copy link

@ninrod ninrod commented Oct 5, 2017

Sorry, in what version was this landed?
@ocean
Copy link

@ocean ocean commented Oct 17, 2017 •
edited

@ninrod This was included in release 1.15, which came out on 10 August 2017.
Zari65
Zari65 reviewed Dec 31, 2017
View changes
Copy link

@Zari65 Zari65 left a comment

:)
@Jargon4072 Jargon4072 mentioned this pull request Feb 9, 2018
Closed
@jasonrudolph jasonrudolph mentioned this pull request Feb 9, 2018
Open
1 task
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request proxy verification-needed
7 participants
@joaomoreno @arek20 @ninrod @ocean @Zari65 @weinand @msftclas