ARM32 build warnings #17898
Comments
|
Build warnings. Most of them are just 32-bit pointer to 64-bit integer cast. /home/pi/github/radare2/libr/..//libr/bin/p/bin_dex.c: In function ‘dex_fields’:
/home/pi/github/radare2/libr/..//libr/bin/p/bin_dex.c:2100:86: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
r_list_append (ret, r_bin_field_new (addr, addr, siz, nam, sdb_fmt ("0x%08"PFMT64x, (ut64)val), fmt, false)); \
^
/home/pi/github/radare2/libr/..//libr/bin/p/bin_dex.c:2109:2: note: in expansion of macro ‘ROW’
ROW ("dex_signature", 8, signature, "[20]c");
^~~ |
|
Can you please update these? I believe some should be fixed already. |
|
Edit: unit tests are all OK. |
|
This test is slow. pi@liumeo-rpi4:~/github/radare2/test $ time ~/bin/prefix/radare2/bin/r2 -Qc 'aa
om~?
s
pi 1
q!
' bins/pe/65535sects.exe
[x] Analyze all flags starting with sym. and entry0 (aa)
65536
0x291120
mov edi, 0x7027aff9
real 1m50.779s
user 1m50.360s
sys 0m0.371s |
|
Thanks for identifying it. I found other slow tests too. We can do different things here:
Ci time is precious. We must take care of it. i cactually wanted to have a benchmark ci. Like the V people do |
|
Is this issue fixed now? |
Yes, tests are all passed now. Only warnings remain. Feel free to close it. |
|
Can you paste the updated list of warnings in here? |
Updated above #17898 (comment) when 5.0.0 released. |
|
Some of them can be solved with an intermediate size_t cast, just if the destination is ut64. For the other cases in afraid its bad code that must be fixed. I can take care of the one in panels unless you started already |
I'm still dealing with pj of lazula's branch. I'll take care of the intermediate casts and you may fix other stuff. |


On my rpi4 (Linux liumeo-rpi4 5.4.79-v7l+ #1373 SMP Mon Nov 23 13:27:40 GMT 2020 armv7l GNU/Linux), all test errors fixed now.
The text was updated successfully, but these errors were encountered: