josharian
Follow
josharian
Follow
Pinned
1,271 contributions in the last year
Less
More
Contribution activity
July 2021
Created 31 commits in 5 repositories
Created 1 repository
Created a pull request in tailscale/tailscale that received 10 comments
optimize throughput a bit
net/tstun: buffer outbound channel net/tstun: eliminate per-packet time.Now calls
+54
−13
•
10
comments
Opened 21 other pull requests in 3 repositories
tailscale/tailscale
4
open
13
merged
1
closed
- debug
- net/dns/resolver: allow an extra alloc for go closure allocation
- net/tstun: buffer outbound channel
- tstime: add Append3339Nano
- tstime/mono: add new package, use everywhere
- tstest/integration: build binaries only once
- tstest/integration: fix filch test flake
- tstest/integration: fix tests on darwin
- wgengine/magicsock: add debug envvar to disable UDP
- run pipe test many times
- .github/workflows: add 'go generate' CI job
- WIP: use io_uring
- safesocket: create the test socket in a temp dir
- wgengine/magicsock: fix latent data race in test
- net/tstun: fix data races
- internal/deephash: 8 bits of output is not enough
- net/tstun: remove multi-case selects from hot code
- ipn/ipnlocal: fix data race
inetaf/netaddr
2
merged
golang/time
1
closed
Reviewed 33 pull requests in 4 repositories
tailscale/tailscale 23 pull requests
- control/noise: implement the 2021 control protocol base transport.
- tstime/mono: add new package, use everywhere
- net/tstun: buffer outbound channel
- util/deephash: hash uint{8,16,32,64} explicitly
- util/deephash: simplify hasher.hashMap
- tstime: add Append3339Nano
- util/deephash: improve cycle detection
- util/deephash: disambiguate hashing of AppendTo
- util/deephash: include type as part of hash for interfaces
- wgengine/magicsock: add debug envvar to disable UDP
- Add Speedtest CLI Command
- wgcfg: add benchmark for FromUAPI
- derp: use a dedicated queue for disco traffic.
- derp: add counters to track the type of dropped packets.
- go.mod: bump wireguard/windows to a version that still exists
- net/uring: add probing capability
- net/uring: add probing capability
- net/uring: add go ntohs
- tstest/integration: help bust cmd/go's test caching
- util/deephash: prevent infinite loop on map cycle
- util/deephash: optimize hashing of byte arrays, reduce allocs in Hash
- net/tstun: remove multi-case selects from hot code
- net/tstun: de-select Wrapper
tailscale/sqlite 6 pull requests
inetaf/netaddr 3 pull requests
go4org/mem 1 pull request
Created an issue in golang/go that received 9 comments
runtime: spurious cycles in time.Now pprof output (vdsoPC and vdsoSP not WAI?)
On linux:
go test -bench=kNow$ -run=NONE -count=3 -cpuprofile=c.p time
go tool pprof -pdf -lines c.p > o.pdf
Result:
o.pdf
Observe the cycles in th…
9
comments
Opened 12 other issues in 4 repositories
tailscale/tailscale
5
open
1
closed
- tstest/integration/vms: NoCredentialProviders error from s3 causing test failures
- tstest/integration/vms: failed downloads are cached, making tests fail forever
- tstest/integration/vms: doesn't support -race
- ipn/ipnlocal: spurious "[unexpected] peerapi listen" log lines
- safesocket: TestBasics fails, unable to bind
- use io_uring