bradfitz
Follow
bradfitz
Follow
Achievements
Achievements
Highlights
- Pro
Pinned
5,108 contributions in the last year
Less
More
Activity overview
Contribution activity
July 2021
Created 73 commits in 4 repositories
Created a pull request in tailscale/tailscale that received 25 comments
util/deephash: optimize hashing of byte arrays, reduce allocs in Hash
name old time/op new time/op delta
Hash-6 173µs ± 4% 101µs ± 3% -41.69% (p=0.000 n=10+9)
HashMapAcyclic-6 101µs ± 5% 105µs ± 3% +3.52% (p=0.001 n=9…
+90
−14
•
25
comments
Opened 33 other pull requests in 2 repositories
tailscale/tailscale
31
merged
1
closed
- cmd/derper: mesh over VPC network
- cmd/tailscale/cli: document that empty string disable exit nodes, routes
- tailcfg: add Node.PrimaryRoutes
- Rename/reword up portmap gateway error message
- control/controlclient: report whether we're in a snap package
- net/dnscache: make Dialer try all resolved IPs
- net/dnscache: cache all IPs per hostname
- ipn/ipnlocal: populate Hostinfo.Package on Android
- wgengine: re-set DNS config on Linux after a major link change
- net/portmapper: disable UPnP on iOS for now
- control/controlclient: don't use regexp in goroutine stack scrubbing
- net/dns/resolver: bound DoH usage on iOS
- wgengine/netstack: implement UDP relaying to advertised subnets
- wgengine/{monitor,router}: restore Linux ip rules when systemd deletes them
- wgengine/router: take a link monitor
- ipn/ipnlocal: fix 'tailscale up' on Windows without GUI
- ipn/ipnlocal: stay out of map poll when down
- net/dns/resolver: upgrade forwarded MagicDNS queries to DoH when IP known
- ipn/localapi: fix inability to receive taildrop files w/ escaped names
- ipn/ipnlocal: save prefs to disk on UpdatePrefs
- derp: remove "fine for now" intentional slow memory leak from derp server
- cmd/derper/derpprobe: add derp prober
- go.mod: bump wireguard/windows to a version that still exists
- ipn/ipnlocal: start to test whether all state transitions save prefs to disk
- tailcfg: break DERPNode.DERPTestPort into DERPPort & InsecureForTests
- Some pull requests not shown.
inetaf/netaddr
1
merged
Reviewed 67 pull requests in 9 repositories
tailscale/tailscale 51 pull requests
- cmd/derper: mesh over VPC network
- wgengine/userspace: add support to automatically enable/disable the tailscale protocol in BIRD.
- tstime/mono: add new package, use everywhere
- disable vm tests on every commit to main
- net/dnscache: make Dialer try all resolved IPs
- tsweb: add case for f64 in logging
- net/portmapper: Add discovery to upnp
- util/deephash: improve cycle detection
- Redo controlclient backtrace scrub without using regex
- util/deephash: disambiguate hashing of AppendTo
- tstest/integration: taildrop integration test
- util/deephash: introduce deliberate instability
- net/portmapper: return correct upnp port
- tstest/integration: add upnp test
- wgengine/{monitor,router}: restore Linux ip rules when systemd deletes them
- tstest/integration: fix filch test flake
- wgengine/router: take a link monitor
- tstest/integration: fix tests on darwin
- util/deephash: make hash type opaque
- Support GRE L2/L3 tunneling protocol.
- util/hujson: initial commit a HuJSON AST parser and packer
- .github/workflows: add 'go generate' CI job
- wgengine/magicsock: add debug envvar to disable UDP
- tailcfg: add IP and Types field to PingRequest
- net/portmapper: add upnp port mapping
- Some pull request reviews not shown.
inetaf/netaddr 8 pull requests
- netaddr: remove unneeded named/bare returns
- netaddr: add functionality to IPRange for feature parity
- netaddr: fix fuzz build
- netaddr: make UnmarshalText methods more consistent with each other
- netaddr: use IsValid instead of Valid
- netaddr: add IP.IsPrivate
- netaddr: add IP.IsUnspecified
- netaddr: add IP.IsGlobalUnicast
tailscale/tailscale-chocolatey 2 pull requests
tailscale/tailscale-android 1 pull request
tailscale/tailscale-synology 1 pull request
tailscale/hujson 1 pull request
bradfitz/art 1 pull request
tailscale/sqlite 1 pull request
go4org/mem 1 pull request
Created an issue in tailscale/tailscale that received 7 comments
when "down" (WantRunning false), tailscaled shouldn't be connected to control
I suspect tailscaled is staying connected to control even when "down". I did a bunch of work to prevent this for the fresh install case earlier in #…
7
comments
Opened 20 other issues in 3 repositories
tailscale/tailscale
10
open
7
closed
- cmd/tailscale: make 'status' show health check errors (notably router)
- cmd/derper: skipping expvar "derp_average_queue_duration_ms" with undeclared Prometheus type
- Ubuntu disables Tailscale's apt sources; actively revert that back?
- Reenable UPnP port mapping on iOS
- dns: skipping bad resolver: [unexpected] non-IP resolver "0.0.0.0/0"
- net/dns/resolver: race well-known DNS IPs less aggressively
- net/nettest: TestPipeTimeout flake
- cmd/derper: mesh derpers using private IPv4 addresses
- CSRF error after cmd/tailscale up sends me to controlplane.tailscale.com to authorize machines
- tailscaled cleanup loop: creating dns cleanup: route ip+net: no such network interface
- cmd/tailscale: can't change --login-server without --force-reauth
- wireguard-windows rewrote its git history or something?
- TestVMIntegrationEndToEnd flake
- getPACWindows: invalid URL "\n" from winhttp; ignoring
- util/deephash: fundamentally kinda broken
- util/deephash: hashMapAcyclic on abort path can leave visited map altered
- util/deephash: infinite loop
inetaf/netaddr
2
closed
golang/go
1
open
207
contributions
in private repositories
Jul 1 – Jul 29